Adding a verification of obj value if not an array so we don't try to use push on a empty string#1195
Open
emitlinks wants to merge 1 commit into
Open
Adding a verification of obj value if not an array so we don't try to use push on a empty string#1195emitlinks wants to merge 1 commit into
emitlinks wants to merge 1 commit into
Conversation
stonebuzz
reviewed
May 12, 2026
Contributor
stonebuzz
left a comment
stonebuzz
left a comment
There was a problem hiding this comment.
Can you adapt CHANGELOG.md
emitlinks
force-pushed
the
emitlinks-patch-dropdown
branch
from
ca0c3a4 to
145210e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
It checks the value of the item that has multiple matches in obj to see if it's an empty string instead of an empty array (this can happen when a multi-value field is checked) in which case it's replaced by an empty array so the code doesn't bug when trying to push a value to a string.