Calculate hidden minor ticks if ticklabelindex is set.#7735
Open
my-tien wants to merge 8 commits intoplotly:masterfrom
Open
Calculate hidden minor ticks if ticklabelindex is set.#7735my-tien wants to merge 8 commits intoplotly:masterfrom
my-tien wants to merge 8 commits intoplotly:masterfrom
Conversation
Contributor
|
Thanks for the PR, @my-tien! Sorry for the delay, I'll review ASAP. Have you looked into the failing image tests yet? |
Contributor
Author
|
Hi @emilykl, not yet! I'll try to do it next week. |
This additional minor tick was added for ticklabel placement via ticklabelindex only. It should never be rendered.
…xes_period2_ticklabelindex
…dden-minor-ticks Undoes update of date_axes_period_ticklabelindex.png and date_axes_period2_ticklabelindex.png because they changed in the main branch. Have to do the update with the output of the next CI run.
…xes_period2_ticklabelindex. This time after having merged master into this branch.
Contributor
Author
|
Failing baseline image tests are resolved. I also updated date_axe_period_ticklabelindex.png and date_axe_period2_ticklabelindex.png. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
ticklabelindexaxis property has an effect even if minor ticks are not visible. Labels are then drawn at possibly invisible minor tick labels n positions away from a major tick.This makes it possible to draw the label for a period to the left of a major tick which was previously not always possible. See this issue for two examples where it was previously not possible: #7423
Disclaimer
I am required to add that…the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.