Fix issues related to set_props() in WebSocket callbacks#3759
Open
CNFeffery wants to merge 11 commits intoplotly:websocket-callbacksfrom
Open
Fix issues related to set_props() in WebSocket callbacks#3759CNFeffery wants to merge 11 commits intoplotly:websocket-callbacksfrom
CNFeffery wants to merge 11 commits intoplotly:websocket-callbacksfrom
Conversation
Contributor
Author
T4rk1n
reviewed
Apr 27, 2026
Comment on lines
+375
to
+376
| if isinstance(value, Patch) or hasattr(value, "to_plotly_json"): | ||
| value = json.loads(to_json(value)) |
Contributor
There was a problem hiding this comment.
To get the full compatibility, it should to_json without condition, this ensure we can get all the supported prop types.
But then this extra loads might be expansive when serializing big object. Maybe instead of _send_json we have _send_plotly_json implemented in base that calls a regular _send(value: str).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Patchobject usingset_props()in thewebsocketcallback. Closes [BUG] 4.2.0rc1 websocket callback can't set_props() with Patch value #3758set_props()to update component-type properties in thewebsocketcallback.