Embedded systems support: no python on board but ssh access is available#83
Open
dketov wants to merge 1 commit into
Open
Embedded systems support: no python on board but ssh access is available#83dketov wants to merge 1 commit into
dketov wants to merge 1 commit into
Conversation
e784765 to
d35f6ec
Compare
Owner
|
Interesting. The implementation looks sound |
pixelb
reviewed
May 15, 2026
| return os.path.join(self.proc, *(str(a) for a in args)) | ||
|
|
||
| def listdir(self, path): | ||
| import subprocess as sp |
Owner
There was a problem hiding this comment.
These imports could be done once in init() I think
pixelb
reviewed
May 15, 2026
Owner
pixelb
left a comment
There was a problem hiding this comment.
os.geteuid() call is invalid now, so should check for startswith("root@") if set
Author
What for? I assume that if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.