fix(azure-functions): replace panic with error returns in deployment plugin - #49
Open
vanshika2720 wants to merge 1 commit into
Open
Conversation
…plugin ExecuteStage and DetermineVersions panicked on an unrecognized stage name or application kind. Both values originate from user-controlled pipeline/application config, so a typo or unsupported kind would crash the plugin process instead of failing the deployment cleanly. Return descriptive errors instead, matching the existing error-returning signatures of these methods. Signed-off-by: Vanshika <pahalvanshikaa@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replaces two
panic()calls in the Azure Functions deployment plugin with descriptive error returns.ExecuteStagenow returns an error when an unsupported pipeline stage name is provided.DetermineVersionsnow returns an error when an unsupported applicationkindis provided.functionkind.Why we need it / Without this PR, what is the problem?
Both panic conditions are reachable through user-controlled configuration: the pipeline stage name and the application
kindfield.A malformed or unsupported value would cause the plugin process to panic instead of failing the affected deployment cleanly. Since these methods already return
erroras part of their SDK-defined interfaces, returning a descriptive error uses the existing failure-handling path without requiring any additional machinery.This keeps the plugin process running and provides an actionable error message for invalid configuration.