Update equals() methods. - #310
Merged
Merged
Conversation
This commit updates the formatting of equals() methods within the SCIM SDK. The primary benefit of this change is that it results in better unit test code coverage statistics. This change does not include new unit tests, since equality evaluation is exercised much better in other Ping Identity test suites. This also includes small updates to classes that did not consistently invoke the superclass in both equals() and hashCode(). Reviewer: vyhhuang JiraIssue: DS-51721
kqarryzada
commented
Jul 31, 2026
| @@ -832,12 +832,9 @@ public boolean equals(@Nullable final Object o) | |||
| { | |||
| return true; | |||
Collaborator
Author
There was a problem hiding this comment.
This could have been folded in with a ternary operator in the return statement, but it wasn't worthwhile in my opinion.
| return Objects.equals(valueFilter, element.valueFilter); | ||
| return o instanceof Element element | ||
| && Objects.equals(valueFilter, element.valueFilter) | ||
| && attribute.equalsIgnoreCase(element.attribute); |
Collaborator
Author
There was a problem hiding this comment.
I updated this to equalsIgnoreCase() since it's more efficient.
vyhhuang
approved these changes
Jul 31, 2026
vyhhuang
left a comment
vyhhuang
left a comment
Collaborator
There was a problem hiding this comment.
These changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the formatting of equals() methods within the SCIM SDK. The primary benefit of this change is that it results in better unit test code coverage statistics. This change does not include new unit tests, since equality evaluation is exercised much better in other Ping Identity test suites.
This also includes small updates to classes that did not consistently invoke the superclass in both equals() and hashCode().
Reviewer: vyhhuang
JiraIssue: DS-51721