Skip to content

deps: replace 'sourcegraph.com/sourcegraph/appdash*' in go.mod - #71691

Merged
ti-chi-bot[bot] merged 1 commit into
release-6.5-20260921-v6.5.0from
fix/release-6.5-20260921-v6.5.0/go-module-appdash
Sep 29, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
release-6.5-20260921-v6.5.0from
fix/release-6.5-20260921-v6.5.0/go-module-appdash

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

  • Chores
    • Updated the source references for Appdash and its data package to use their corresponding GitHub-hosted locations. Existing versions remain unchanged. This maintenance update does not add, remove, or change product features or behavior, and end-user workflows are unaffected. The references are now consistent across the project’s dependency configurations.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: b671fb6c-4b73-4991-850d-05319cdb4b98

📥 Commits

Reviewing files that changed from the base of the PR and between ca04f92 and 44e2de1.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • DEPS.bzl
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The Go and Bazel dependency declarations now map appdash and appdash-data to their corresponding github.com/sourcegraph module paths. The versions remain unchanged, and the Bazel checksums are updated.

Changes

Appdash module path updates

Layer / File(s) Summary
Update appdash module paths
go.mod, DEPS.bzl
The Go and Bazel dependency declarations map appdash and appdash-data to their corresponding github.com/sourcegraph paths. The versions remain unchanged; the Bazel checksums are updated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: bb7133

Merge Risk: ⚪ Minimal · up to 44e2d

The dependency updates preserve the existing Appdash import paths and select the intended pinned modules in Go and Bazel. No actionable merge risk was identified; normal build checks remain appropriate.

Architecture Summary

Architecture risk: 🔵 Low · up to 44e2d

The change affects 2 systems.

Changed systems: DEPS.bzl, go.mod

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — DEPS.bzl (service) was modified; 1 changed file maps to changed impact.
  • observed — go.mod (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in DEPS.bzl: The appdash dependency adds a replacement path of github.com/sourcegraph/appdash and updates its checksum; its version is unchanged.
  • observed — Modified behavior in DEPS.bzl: The appdash-data dependency adds a replacement path of github.com/sourcegraph/appdash-data and updates its checksum.
  • observed — Modified behavior in go.mod: Adds module replacements mapping the two sourcegraph.com/sourcegraph module paths to the corresponding github.com/sourcegraph paths, preserving their versions.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the release note. It omits the required issue number, problem summary, change description, test checklist, side effects, and documentation checklist. Add the required sections from the repository template, including an issue reference, problem summary, change details, testing status, side effects, documentation impact, and release note.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency path replacement in go.mod. It matches the main objective, although it does not mention the related DEPS.bzl update.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the paths in place
Two modules find their GitHub space
Their versions stay, their checksums change
The Go and Bazel lists rearrange
Then off I hop through clover’s range

Comment @coderabbitai help to get the list of available commands.

@bb7133 bb7133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2026

@wjhuang2016 wjhuang2016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against merged #51835. No blocking issue found. All four ports contain the same dependency changes: the original import paths and pinned versions are retained, while Go and Bazel consistently resolve appdash/appdash-data from GitHub. Both module and go.mod checksums match the Go checksum database. No unrelated dependency changes found. Static review only; no local build/tests or Bazel regeneration were run. Some CI checks are still pending.

@ti-chi-bot

ti-chi-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-29 08:43:25.933134388 +0000 UTC m=+699131.158355495: ☑️ agreed by bb7133.
  • 2026-09-29 08:48:29.005410717 +0000 UTC m=+699434.230631825: ☑️ agreed by wjhuang2016.

@ti-chi-bot
ti-chi-bot Bot merged commit 8aa4b71 into release-6.5-20260921-v6.5.0 Sep 29, 2026
9 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the fix/release-6.5-20260921-v6.5.0/go-module-appdash branch September 29, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants