Skip to content

deps: replace 'sourcegraph.com/sourcegraph/appdash*' in go.mod - #71690

Merged
ti-chi-bot[bot] merged 1 commit into
release-6.5-20260928-v6.5.4from
fix/release-6.5-20260928-v6.5.4/go-module-appdash
Sep 29, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
release-6.5-20260928-v6.5.4from
fix/release-6.5-20260928-v6.5.4/go-module-appdash

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

  • Chores
    • Updated internal source configuration and verification values. The referenced software versions remain unchanged.
    • No user-facing changes are included in this release.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 9b489e79-decd-49a6-926d-42723bfe456a

📥 Commits

Reviewing files that changed from the base of the PR and between 846c696 and dbec302.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • DEPS.bzl
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The appdash and appdash-data dependency declarations now use corresponding GitHub module paths in DEPS.bzl and go.mod. The dependency versions remain unchanged in DEPS.bzl; the Go module replacements specify versions.

Changes

Appdash module path replacements

Layer / File(s) Summary
Update appdash dependency declarations
DEPS.bzl, go.mod
DEPS.bzl replaces both source repository paths and updates their checksums. go.mod maps both source module paths to the corresponding GitHub paths at pinned versions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to dbec3

The appdash dependency declarations resolve to the intended GitHub modules with matching versions and checksums. No merge-blocking dependency-resolution issue was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to dbec3

The change affects 2 systems.

Changed systems: DEPS.bzl, go.mod

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — DEPS.bzl (service) was modified; 1 changed file maps to changed impact.
  • observed — go.mod (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in DEPS.bzl: The appdash dependency now replaces sourcegraph.com/sourcegraph/appdash with github.com/sourcegraph/appdash, and its checksum changes; the version remains unchanged.
  • observed — Modified behavior in DEPS.bzl: The appdash-data dependency now replaces sourcegraph.com/sourcegraph/appdash-data with github.com/sourcegraph/appdash-data, and its checksum changes; the version remains unchanged.
  • observed — Modified behavior in go.mod: Adds replacements mapping the two sourcegraph.com/sourcegraph module paths to their corresponding github.com/sourcegraph paths, pinned to the listed versions.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the release note but omits the required Issue Number, problem summary, change description, checklist, side effects, and documentation sections. Add the required Issue Number with a linked issue, describe the problem and implementation, complete the test checklist, and address side effects and documentation impact.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: replacing the appdash dependency references in go.mod. It is concise and follows the repository title format.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the module trail,
Two paths now point where GitHub hosts.
The versions keep their place in line,
While checksums shift beneath the names.
I nibble clover, close the file,
And hop along the source-code lane.

Comment @coderabbitai help to get the list of available commands.

@bb7133 bb7133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 29, 2026

@wjhuang2016 wjhuang2016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against merged #51835. No blocking issue found. All four ports contain the same dependency changes: the original import paths and pinned versions are retained, while Go and Bazel consistently resolve appdash/appdash-data from GitHub. Both module and go.mod checksums match the Go checksum database. No unrelated dependency changes found. Static review only; no local build/tests or Bazel regeneration were run. Some CI checks are still pending.

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-29 08:43:06.844881832 +0000 UTC m=+699112.070102939: ☑️ agreed by bb7133.
  • 2026-09-29 08:48:18.763054964 +0000 UTC m=+699423.988276081: ☑️ agreed by wjhuang2016.

@ti-chi-bot
ti-chi-bot Bot merged commit 1054e23 into release-6.5-20260928-v6.5.4 Sep 29, 2026
9 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the fix/release-6.5-20260928-v6.5.4/go-module-appdash branch September 29, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants