dumpling: pin MinIO CI downloads to GitHub releases - #71291
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe installer now downloads pinned MinIO and MC release binaries from GitHub. It verifies both binaries with architecture-specific SHA256 checksums before making them executable. ChangesMinIO dependency downloads
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The pinned downloads, checksums, architecture handling, and downstream binary paths are consistent; the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each binary bright Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #71291 +/- ##
================================================
- Coverage 76.3029% 72.4146% -3.8883%
================================================
Files 2041 2104 +63
Lines 555347 595418 +40071
================================================
+ Hits 423746 431170 +7424
- Misses 130701 163007 +32306
- Partials 900 1241 +341
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@coderabbitai[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coderabbitai[bot], joechenrh, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #71290
Problem Summary:
The Dumpling workflow fails before building TiDB or running integration tests because the MinIO server download returns HTTP 410 Gone. The subsequent
mcdownload endpoint is also retired, so both downloads need replacement. This affects unrelated PRs and cannot be resolved by retrying the unchanged workflow.Example: https://github.com/pingcap/tidb/actions/runs/35178151909/job/105066506521
What changed and how does it work?
This is a small, temporary CI-only unblock confined to
dumpling/install.sh:RELEASE.2025-09-07T16-13-09ZandmcRELEASE.2025-08-13T08-35-41Zfrom their official GitHub release assets instead of the retired download endpoints.bin/minioandbin/mcpaths, and existing fail-fast behavior.No TiDB code, S3 test behavior, workflow configuration, or other dependency downloads are changed.
The selected prebuilt MinIO server predates the fix for CVE-2025-62506. This is an isolated-test dependency stopgap, not a production upgrade recommendation. A durable replacement should use a validated, checksummed CI artifact built from patched source rather than treating this archived binary pin as a long-term solution.
Check List
Tests
Validation used the Ready profile:
All checks passed. Downloaded all four actual GitHub release binaries using
curl --fail --location, hashed them withshasum -a 256, and checked their ELF architectures withfile. All digests match the pins in the installer for amd64 and arm64.A local-only offline shell harness rejected the retired URL before the fix and passed after the fix for
x86_64,aarch64, andarm64, checking pinned URLs, output paths, checksum selection, and verification-before-chmod ordering. That harness is not included in this PR.The full Dumpling/S3 integration test was not run locally: the Docker daemon was unavailable, and the Linux binaries were not executed on the macOS host. Runtime compatibility still needs validation by the Dumpling CI matrix.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit