Repository navigation
Fix unchecked request-body flatten errors in apache2handler - #25176
Open
joshtrichards wants to merge 1 commit into
Open
joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
php_apache_sapi_read_post() checks ap_get_brigade() errors but ignores the return value of apr_brigade_flatten(). If a bucket read fails during flattening, APR returns before updating the supplied length. The callback then counts the requested length as successfully read, potentially reporting bytes that were not written into the destination buffer. Apache's core input filter normally reads socket buckets and propagates errors through ap_get_brigade(), so ordinary network failures are already handled. This change defensively handles any bucket-read failure occurring during the subsequent flatten operation; no such failure has been demonstrated with the standard input-filter chain. Check the flatten result after cleaning up the brigade and return zero on failure, matching the existing handling of ap_get_brigade() errors. Successful reads are unchanged. Assisted-by: Copilot:gpt-6.1-sol
devnexen
approved these changes
Nov 4, 2026
devnexen
left a comment
devnexen
left a comment
Member
There was a problem hiding this comment.
in practice, seems it require very specific conditions to happen, master is the appropriate branch indeed IMHO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_apache_sapi_read_post()checksap_get_brigade()errors but ignores the return value ofapr_brigade_flatten().If a bucket read fails during flattening, APR returns before updating the supplied length. The callback then counts the requested length as successfully read, potentially reporting bytes that were not written into the destination buffer.
Apache's core input filter normally reads socket buckets and propagates errors through
ap_get_brigade(), so ordinary network failures are already handled. This change defensively handles any bucket-read failure occurring during the subsequent flatten operation; no such failure has been demonstrated with the standard input-filter chain.Check the flatten result after cleaning up the brigade and return zero on failure, matching the existing handling of
ap_get_brigade()errors. Successful reads are unchanged.Related: