ssl: add ability to control kex groups and sig algs#17
Open
huwcbjones wants to merge 3 commits into
Open
Conversation
huwcbjones
commented
Jun 17, 2026
huwcbjones
commented
Contributor
- rtmpserver: add kex-groups prop
- rtmpserver: add tls-sig-algs prop
huwcbjones
force-pushed
the
huw/ssl-ctx-options
branch
3 times, most recently
from
26e0060 to
560603d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurability for TLS key exchange groups and TLS signature algorithms in PexRTMPServer by introducing new GObject properties and plumbing them through client/server SSL context creation.
Changes:
- Extend SSL helper APIs (
ssl_add_incoming/ssl_add_outgoing) to acceptkex_groupsandsig_algs. - Add new server properties/fields to carry these TLS settings and pass them into client SSL setup.
- Apply the configured groups/signature algorithms to OpenSSL
SSL_CTXfor incoming/outgoing connections (OpenSSL 3+).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/ssl.h | Updates SSL helper function prototypes to accept kex groups and sig alg lists. |
| utils/ssl.c | Attempts to set OpenSSL SSL_CTX kex groups and signature algorithm lists based on new parameters. |
| src/pexrtmpserver.c | Adds new GObject properties/fields and passes them into client SSL creation paths. |
| src/client.h | Updates client SSL helper prototypes to accept and forward new TLS config parameters. |
| src/client.c | Forwards new TLS config parameters to SSL helper functions when creating SSL contexts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
huwcbjones
force-pushed
the
huw/ssl-ctx-options
branch
from
560603d to
52abd77
Compare
Comment on lines
+1274
to
+1277
| g_object_class_install_property (gobject_class, PROP_TLS_SIG_ALGS, | ||
| g_param_spec_string ("tls-sig-algs", "TLS Sig Algs", | ||
| "List of enabled TLS signature algorithms", DEFAULT_SIG_ALGS, | ||
| G_PARAM_CONSTRUCT | G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); |
Contributor
There was a problem hiding this comment.
can we add some coverage for this properties?
huwcbjones
force-pushed
the
huw/ssl-ctx-options
branch
from
52abd77 to
50fa0fe
Compare
Comment on lines
+1274
to
+1277
| g_object_class_install_property (gobject_class, PROP_TLS_SIG_ALGS, | ||
| g_param_spec_string ("tls-sig-algs", "TLS Sig Algs", | ||
| "List of enabled TLS signature algorithms", DEFAULT_SIG_ALGS, | ||
| G_PARAM_CONSTRUCT | G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); |
Contributor
There was a problem hiding this comment.
can we add some coverage for this properties?
This was referenced Jun 23, 2026
huwcbjones
force-pushed
the
huw/ssl-ctx-options
branch
from
50fa0fe to
5f53585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.