[BUGFIX] pyroscope: fix timerange#725
Merged
Merged
Conversation
prakhar29jain
approved these changes
Jul 9, 2026
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Gladorme
force-pushed
the
fix/pyroscope
branch
2 times, most recently
from
1770d59 to
941c14f
Compare
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Nexucis
reviewed
Jul 10, 2026
shahrokni
reviewed
Jul 10, 2026
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
shahrokni
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix pyroscope timerange query params: https://github.com/grafana/pyroscope/blob/254c6885170b4ac35d3c8933ffdbfd2f955fade2/api/types/v1/types.proto#L64
Improving the display on the way too. When changing datasource, input options were not updated, because client is "enabled", but on old spec so the query is executed but with wrong data. That why I put client as useQuery key instead of datasource selector. I would prefer to use datasource name as key, but it may need more work.
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes