Skip to content

Clean up comments #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeltz merged 4 commits into from
Aug 5, 2026
Merged

Clean up comments #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da02faf
Fix typos in comments
jeltz Aug 4, 2026
0583dac
Remove outdated comment inherited from pg_stat_statements
jeltz Aug 4, 2026
3967c5c
Improve comments in pgsm_delete_query_stats()
jeltz Aug 4, 2026
833087b
Improve comment about attaching to the DSA
jeltz Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/hash_query.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,18 +177,16 @@ pgsm_attach_shmem(void)

/*
* We want the dsa to remain valid throughout the lifecycle of this
* process. so switch to TopMemoryContext before attaching
* process so switch to TopMemoryContext before attaching.
*/
oldcontext = MemoryContextSwitchTo(TopMemoryContext);

pgsmStateLocal.dsa = dsa_attach_in_place(pgsmStateLocal.shared_pgsmState->raw_dsa_area,
NULL);

/*
* pin the attached area to keep the area attached until end of session or
* explicit detach.
*/
/* Keep area attached until end of session */
dsa_pin_mapping(pgsmStateLocal.dsa);

MemoryContextSwitchTo(oldcontext);
}

Expand Down
16 changes: 2 additions & 14 deletions src/pg_stat_monitor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,7 +1274,7 @@ pgsm_update_counters(Counters *counters,
int parallel_workers_launched)
{
/*
* Only the update totals here, min/max/mean will be computed in
* Only update the totals here, min/max/mean will be computed in
* pgsm_merge_counters.
*/
counters->plantime.total_time += plan_total_time;
Expand Down Expand Up @@ -1597,6 +1597,7 @@ pgsm_delete_query_stats(uint64 queryid)
if (lentries == NIL)
return;

/* Look at end of list first */
stats = (pgsmQueryStats *) llast(lentries);
if (stats->key.queryid == queryid)
{
Expand All @@ -1606,12 +1607,6 @@ pgsm_delete_query_stats(uint64 queryid)
return;
}

/*
* The rest of the code is just paranoia. In theory this list is a stack,
* and we always want to remove the last item. Similarly, in the getter
* method we are always looking for the last item.
*/

foreach(lc, lentries)
{
stats = lfirst(lc);
Expand Down Expand Up @@ -1700,13 +1695,6 @@ pgsm_subxact_callback(SubXactEvent event, SubTransactionId mySubid,

/*
* Store some statistics for a statement.
*
* If queryId is 0 then this is a utility statement and we should compute
* a suitable queryId internally.
*
* If jstate is not NULL then we're trying to create an entry for which
* we have no statistics as yet; we just want to record the normalized
* query string. total_time, rows, bufusage are ignored in this case.
*/
static void
pgsm_store(const pgsmQueryStats *stats)
Expand Down
Loading