PS-11479 Add vault_namespace support to component_keyring_vault - #6123
Open
jstack-godaddy wants to merge 1 commit into
Open
PS-11479 Add vault_namespace support to component_keyring_vault#6123jstack-godaddy wants to merge 1 commit into
jstack-godaddy wants to merge 1 commit into
Conversation
https://perconadev.atlassian.net/browse/PS-11479 Add optional vault_namespace configuration parameter to component_keyring_vault. When set, sends the X-Vault-Namespace HTTP header on every Vault API request, enabling use with HashiCorp Vault Enterprise and OpenBao deployments that enforce namespaces. The field is optional and backward-compatible — omitting it preserves existing behavior. Changed files: - config/config.h: added vault_namespace field to Config_pod - config/config.cc: parse optional vault_namespace key (trimmed), show in status output - backend/vault_curl.cc: conditionally append X-Vault-Namespace header in setup_curl_session() - unittest/gunit/.../vault_config-t.cc: two new unit tests for valid and invalid namespace values - mysql-test/suite/.../generate_comp_config_content.inc: MTR support via vault_conf_namespace/$MTR_VAULT_NAMESPACE - README: document the new optional parameter
Author
|
@percona-ysorokin Happy Friday. I hope you are doing great. I would appreciate if you could take a look at my PR. According to the contribution documentation I should assign this to you but I don't have permissions to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-11479
Add optional vault_namespace configuration parameter to component_keyring_vault. When set, sends the X-Vault-Namespace HTTP header on every Vault API request, enabling use with HashiCorp Vault Enterprise and OpenBao deployments that enforce namespaces. The field is optional and backward-compatible — omitting it preserves existing behavior.
This feature is already available in https://github.com/percona/pg_tde for Postgres.
Changed files: