fix: prevent identity mismatch on reconnect during in-flight retrieveId #1362
Open
dearlordylord wants to merge 1 commit into
Open
fix: prevent identity mismatch on reconnect during in-flight retrieveId #1362dearlordylord wants to merge 1 commit into
dearlordylord wants to merge 1 commit into
Conversation
new Peer() → disconnect() → reconnect() while retrieveId() is in-flight creates a WebSocket registered with a null ID on the server, causing all signaling to silently fail. Three independent fixes: - Guard _initialize() against destroyed/disconnected state - Abort in-flight retrieveId() fetch on disconnect via AbortController - Reject reconnect() when _lastServerId is null (no ID was ever assigned)
|
Sharp catch — the in-flight retrieveId vs disconnect race is exactly the kind of bug that fails silently and eats days. Cancelling the fetch with an AbortController and guarding _initialize() against a destroyed peer is the right move, and the null _lastServerId path opening a socket with a null ID is especially nasty since nothing throws. Looks like it's been sitting without a review since March though. Is peerjs-server still maintained from your side, or are you running a fork? Curious how you ended up handling reconnect identity in production given the repo's pace. |
Author
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new Peer()(no id) →disconnect()→reconnect()whileretrieveId()is in-flight creates a WebSocket registered with a null ID on the server, causing all signaling to silently failThree independent root causes fixed:
Guard
_initialize(): lateretrieveId()resolve no longer runs on a destroyed/disconnected peerAbortController: in-flight
retrieveId()fetch is cancelled ondisconnect()viaAbortSignalNull check in
reconnect(): emits error instead of opening a socket with null ID when_lastServerIdwas never assignedseems to be partially related to #1289