Conversation
Add ability to configure which XSL files are used for scoreboard HTML generation in the system.pc2.yaml at contest configuration. Add ability to configure which XSL files is used for the Standings HTML pane on the Administrator view in the system.pc2.yaml at contest configuration. If neither are specified, the legacy defaults are used.
Add pane to allow editing of which XSL files are used to generate scoreboards. There are still a couple of TODO's in here.
Add method to StringUtilities to company 2 string arrays to see if they have the same strings (in no particular order). Add button enabling code based on selections.
johnbrvc
requested review from
JoeTerlizzi,
SamanwaySadhu,
clevengr and
kkarakas
September 16, 2026 20:20
Use ADD_SETTING permission to control whether an account can modify the xsl file list for scoreboard generation. Add AccountListener to ScoreboardXSLPane to update permissions if they change. Add ScoreboardXSLPaneto PluginLoadPane. Add ScoreboardXSLPaneto scoreboard client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Allows configuration of which XSL files to use for scoreboard webpage generation. This can be done from the configuration files (
system.pc2.yaml) as well as the GUI via a new tab (Scoreboard XSL) on the administrator's "Configure Contest" tab.In addition, this PR allows a descriptive comment to be placed in a XSL file so it will appear next to the XSL file name on the new Scoreboard XSL tab. The comment must appear within the first 5 lines of the XSL file (that number of lines is a build-time constant). In order to be recognized as a description, the comment must match the following regular expression:
For example:
The capture group in the RE would be: This would be the description text!
The new tab looks like this:
Issue which the PR addresses
Fixes #1252
Environment in which the PR was developed (OS,IDE, Java version, etc.)
java version "1.8.0_321"
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.321-b07, mixed mode)
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
Test suite 1 - GUI:
data/xslfolder are checked and they all say "No description" in the Description column.pc2v9/data/xsl foldersince you'll be extracting some test files over this folder.pc2v9/data/xslfolder. This will replace 4 xsl files:full.xsl,fullps.xml,index.xsl,index_mobile.xslwith versions that have the new Description comment in them as described above in the PR description.index.xslandfull.xsl. Watch which buttons become enabled/disabled while doing this.index.xslandfull.xslagain.pc2v9/public_htmlfolder. Note that onlyindex.htmlandfull.htmlwere generated.public_htmlfolder (check the dates on the files).Test suite 2 - Loading from `system.pc2.yaml`:
system.pc2.yamlfile in the sampleclics_sumithello/configfolder. Add the linescoreboard-xsl-files: index.xsl,full.xsl,summary.xslto the file (you can put it at the beginning of the file if you like, or the end)Be sure to restore the original data/xsl files that were overwritten when you extract the ZIP file.
Be sure to restore the state of system.pc2.yaml in the sample contest to its original content. (Delete the line you added).