make diffrax compatible with new lineax pre-release#751
Merged
patrick-kidger merged 1 commit intopatrick-kidger:mainfrom May 1, 2026
Merged
make diffrax compatible with new lineax pre-release#751patrick-kidger merged 1 commit intopatrick-kidger:mainfrom
patrick-kidger merged 1 commit intopatrick-kidger:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two failures were caused by recent lineax changes
Failure 1
Caused by lineax commit c1fe3b3 (Removed AuxLinearOperator) which removed the
_NoAuxOutwrapper onJacobianLinearOperator.out_structure()which go througheqxi.cached_filter_eval_shape(fn, self.x). But I can't say I really understand this deeply.Failure 2
patrick-kidger/lineax#200 means that
is_symmetricnow consultsis_positive/negatuve_semidefinitebutTestLinearOperatornever declared this. We could default to returningFalsein lineax, but just adding the registrations toTestLinearOperatoris the simple option.