Repository navigation
Conversation
DownloadService.swap() started broadcasting onSongsChanged() to all listeners during the Media3 port so the session would see queue moves. NowPlayingFragment answers that by clearing and refilling its list and calling notifyDataSetChanged(), which cancels the ItemTouchHelper drag that is still in progress. Refresh only the Media3 session after a swap instead, as the UI list is already updated by the drag itself.
unpinSong renames the pinned file to its .complete name and then updated the media store row, but passed the new path as the source and the old path as the target. The row is still stored under the old path, so the update never matched and the media store kept pointing at the stale name. Pass the old (saved) path first, consistent with DownloadFile.unpin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadService.swap() started broadcasting onSongsChanged() to all listeners during the Media3 port so the session would see queue moves. NowPlayingFragment answers that by clearing and refilling its list and calling notifyDataSetChanged(), which cancels the ItemTouchHelper drag that is still in progress.
Refresh only the Media3 session after a swap instead, as the UI list is already updated by the drag itself.