fix: reposition transient/popup windows into visible area on focus and demands-attention - #1175
Open
Conversation
…d demands-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Transient/popup windows (dialogs, modals, notifications) are real MetaWindows rejected by
add_filter, so they're never in the scrollable clone container and the existingensureViewport/scroll machinery can't reach them. Two paths were broken:focus_handlerearly-returned for transients without repositioning them, leaving them clamped at the monitor edge.window-demands-attentionhandler existed, so background-spawned popups stayed invisible.Fix adds a
repositionTransienthelper that clamps the window's frame rect to its monitor's work area viamove_frame, then calls it on both paths:focus_handlerbefore the early return for transientswindow-demands-attentionsignal handler that repositions attention-demanding popups without stealing focusWhy
This change resolves the target issue or improvement.
How to test
Verify that the project builds/runs correctly and the specific bug/improvement is addressed.
Fixes #1174