Log the repo-wide reverse dependency graph build at INFO - #23682
Open
jasonwbarnett wants to merge 1 commit into
Open
jasonwbarnett wants to merge 1 commit into
jasonwbarnett wants to merge 1 commit into
Conversation
`map_addresses_to_dependents` resolves dependencies for every target in
the repo, including import inference, and dominates the wall time of the
`dependents` goal and of any run that passes `--changed-dependents`. Its
workunit is declared at `DEBUG`, so at default verbosity nothing in the
log attributes that time to anything, and the only way to see it is to
re-run the whole thing under `-ldebug`.
Declare the rule at `INFO` instead. The engine already logs a completed
workunit's description and elapsed time at the workunit's own level, so
the promotion alone surfaces the work and its cost in ordinary build
logs, once per session:
Completed: Map all targets to their dependents (42.3s)
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NsX7odrmuYiDedSg4FwysE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_addresses_to_dependentsresolves dependencies for every target in the repo and dominates the wall time of thedependentsgoal and of any run passing--changed-dependents, but its workunit is declaredDEBUG, so at default verbosity nothing in the log accounts for that time. Declaring itINFOis all that is needed — since #22992 the engine logs a completed workunit's description and elapsed time at the workunit's own level. Follow-on to #21587.From source at 2.34.0.dev3,
pants dependents src/python/pants/util/strutil.pyin this repo:mainlogs no such line; the 383 dependents printed are identical, anddependents_test.pypasses.LLM assistance (policy): the one-line change and the release note were LLM-written. I directed the change and ran the verification above.