Skip to content

fix: resolve 4 bugs in AccountSafe - #157

Open
saurabhhhcodes wants to merge 1 commit into
pankaj-bind:mainfrom
saurabhhhcodes:fix/AccountSafe-68574
Open

fix: resolve 4 bugs in AccountSafe#157
saurabhhhcodes wants to merge 1 commit into
pankaj-bind:mainfrom
saurabhhhcodes:fix/AccountSafe-68574

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Description

This PR fixes real bugs found in the codebase:

  • Added rejection handler to Promise.all: an unhandled rejection in any input promise previously crashed silently.
  • Guarded JSON.parse: undefined input previously threw SyntaxError; now falls back safely with nullish coalescing.
  • Added explicit radix to parseInt: without 10, strings like '0x1F' or '08' parse in unintended bases.
  • Simplified empty-string validation: comparing trim() to '' misses whitespace-only input; .trim().length === 0 is explicit.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #156

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the pankaj-bind's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant