Skip to content

fix: fail early if no pacts found for verification#412

Open
YOU54F wants to merge 1 commit into
masterfrom
fix/issue-411
Open

fix: fail early if no pacts found for verification#412
YOU54F wants to merge 1 commit into
masterfrom
fix/issue-411

Conversation

@YOU54F

@YOU54F YOU54F commented Jul 15, 2026

Copy link
Copy Markdown
Member

fixes #411

@bekasovoleg

Copy link
Copy Markdown

LGTM 👍🏻

minor: provider/consumer names aren't consistent across the pact tests - the same app gets different names - might be worth keeping the names in sync and use the same name everywhere - u2y

  - http_client_spec.rb - 'pact-ruby-test-app', 'pact-ruby-test-app'
  - grpc_client_spec.rb - 'pact-ruby-test-app', 'pact-ruby-test-app'
  - message_spec.rb - 'Test Message Consumer', 'Test Message Provider'
  - kafka_spec.rb - 'pact-ruby-test-app', 'pact-ruby-test-app-kafka'
  - plugin_matt_http_spec.rb - 'myconsumer', 'myprovider'
  - plugin_matt_sync_message_spec.rb - 'myconsumer', 'myprovider'
  - plugin_matt_async_message_spec.rb - 'matttcpconsumer', 'matttcpprovider'
  - plugin_grpc_sync_message_spec.rb - 'pact-ruby-test-app', 'pact-ruby-test-app'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pact:verify passes vacuously - provider names in verification specs don't match generated pacts

2 participants