Remove unsafe from generated MESSAGE_ID constants - #194
Merged
felixvanoost merged 3 commits intoSep 2, 2026
Conversation
felixvanoost
force-pushed
the
remove-unsafe-from-message-id
branch
from
September 2, 2026 18:48
3c2a17b to
fe7cabc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
trnila
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces unsafe code in the generated
MESSAGE_IDconstants with<StandardId/ExtendedId>::new(...).unwrap().Option::unwrap()has been available inconstcontexts since Rust 1.83 (the current MSRV is 1.88).The generated code no longer contains any unsafe blocks after this change.