Repository navigation
fix: synchronize profile language with form state - #482
Open
ClarenceStark wants to merge 1 commit into
Open
ClarenceStark wants to merge 1 commit into
ClarenceStark wants to merge 1 commit into
Conversation
|
@ClarenceStark is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: 曾泽梓 <3038736583@qq.com>
ClarenceStark
force-pushed
the
codex/fix-profile-language-state
branch
from
October 5, 2026 03:13
5f021a2 to
b6673dd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The profile language radio group receives a
defaultValue, but its React Hook Form field is never initialized. An untouched profile is therefore treated as changed, name-only saves omit the displayed language, and a user loaded after mount does not update the selection.Initialize the language field with the other saved profile fields and control the radio group from that field.
Validation: 4 Jest component tests pass (baseline 3 failures), using the real React Hook Form and Radix radio controls. Covers pristine state, delayed user data, name-only submission, and explicit language change. Network/user-store providers and ResizeObserver are isolated. Node 22.12.0; no live account update.
AI-assisted implementation and regression tests.