Skip to content

fix: match the API limit of five Lab comment images - #481

Open
ClarenceStark wants to merge 1 commit into
oss-compass:mainfrom
ClarenceStark:codex/fix-comment-attachment-limit
Open

ClarenceStark wants to merge 1 commit into
oss-compass:mainfrom
ClarenceStark:codex/fix-comment-attachment-limit

Conversation

@ClarenceStark

Copy link
Copy Markdown

The Lab comment input allows six pictures from either the picker or clipboard, while both CreateLabModelComment and UpdateLabModelComment in compass-web-service reject more than five. Users can therefore prepare a comment that the API will always reject.

Use one five-image limit for both input paths and update the warning. Existing images loaded into the edit form count toward the same limit.

Validation: 6 component tests pass in Jest/Node 22.12.0 (baseline 4 failed, 2 passed). Each input route rejects six new images, accepts five, and rejects adding two to an existing four. File conversion and image preview are isolated; live upload/API submission was not exercised.

Backend contract: app/graphql/mutations/create_lab_model_comment.rb and update_lab_model_comment.rb at oss-compass/compass-web-service main.

AI-assisted implementation and local regression testing.

@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown

@ClarenceStark is attempting to deploy a commit to the codersett's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ClarenceStark
ClarenceStark force-pushed the codex/fix-comment-attachment-limit branch from 209f119 to 31e7855 Compare October 5, 2026 03:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant