Repository navigation
fix: match the API limit of five Lab comment images - #481
Open
ClarenceStark wants to merge 1 commit into
Open
ClarenceStark wants to merge 1 commit into
ClarenceStark wants to merge 1 commit into
Conversation
|
@ClarenceStark is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: 曾泽梓 <3038736583@qq.com>
ClarenceStark
force-pushed
the
codex/fix-comment-attachment-limit
branch
from
October 5, 2026 03:13
209f119 to
31e7855
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lab comment input allows six pictures from either the picker or clipboard, while both
CreateLabModelCommentandUpdateLabModelCommentin compass-web-service reject more than five. Users can therefore prepare a comment that the API will always reject.Use one five-image limit for both input paths and update the warning. Existing images loaded into the edit form count toward the same limit.
Validation: 6 component tests pass in Jest/Node 22.12.0 (baseline 4 failed, 2 passed). Each input route rejects six new images, accepts five, and rejects adding two to an existing four. File conversion and image preview are isolated; live upload/API submission was not exercised.
Backend contract:
app/graphql/mutations/create_lab_model_comment.rbandupdate_lab_model_comment.rbat oss-compass/compass-web-service main.AI-assisted implementation and local regression testing.