Repository navigation
fix: keep IME confirmation from submitting comments - #480
Open
ClarenceStark wants to merge 1 commit into
Open
ClarenceStark wants to merge 1 commit into
ClarenceStark wants to merge 1 commit into
Conversation
|
@ClarenceStark is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: 曾泽梓 <3038736583@qq.com>
ClarenceStark
force-pushed
the
codex/fix-comment-ime-submit
branch
from
October 5, 2026 03:12
fc5b88d to
e0ad39c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Enter to confirm a Chinese/Japanese IME candidate currently submits the comment immediately. The same handler appears in Lab comments and the sandbox, hatch, and graduation clarification inputs.
Ignore submit handling while the native keyboard event is composing, including the legacy IME key code 229. A subsequent normal Enter still submits.
Validation: Node 22.12.0 / Jest,
src/common/components/CommentInputComposition.test.tsx: 16 passing component tests; baseline 8 failed and 8 passed. Tests render each of the four real input components and cover composing Enter, key code 229, ordinary Enter, Shift+Enter, and loading state. Viewer/i18n providers are mocked; no live backend or physical IME/browser session was exercised.AI-assisted implementation and regression testing.