Repository navigation
fix: validate the actual host of source repository URLs - #479
Open
ClarenceStark wants to merge 1 commit into
Open
ClarenceStark wants to merge 1 commit into
ClarenceStark wants to merge 1 commit into
Conversation
|
@ClarenceStark is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: 曾泽梓 <3038736583@qq.com>
ClarenceStark
force-pushed
the
codex/fix-source-repository-url-validation
branch
from
October 5, 2026 03:12
6782bd2 to
fb2dffa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source URL validator shared by the sandbox, hatch, and graduation application forms accepts unrelated sites whenever
github.com,gitee.com, orgitcode.comappears anywhere in the input. For example,https://example.org/github.com/owner/repopasses. It also rejects valid mixed-case hostnames.Parse the URL and validate its HTTP(S) scheme, exact supported hostname, and owner/repository path. This is form validation, not a server-side security boundary.
Validation: Node 22.12.0 / Jest,
src/modules/oh/utils/form.test.ts: baseline 10 failures; fixed 17 passing cases. Covers supported hosts, mixed-case hosts, misleading host/path/query/userinfo strings, missing repository paths, and unchanged commit SHA validation. Full form submission/backend integration was not run.AI-assisted implementation and tests.