Skip to content

Add unit tests for conductor SONiC BGP/VLAN/Loopback/VRF helpers #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berendt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add unit tests for conductor SONiC BGP/VLAN/Loopback/VRF helpers #2290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osism/tasks/conductor/sonic/config_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,11 +1197,11 @@ def get_vrf_for_interface(interface_name):
netbox_interface_name = netbox_interfaces[port_name][
"netbox_name"
]
if netbox_interface_name in interface_ips:
if interface_ips and netbox_interface_name in interface_ips:
local_ipv4 = interface_ips[netbox_interface_name].split(
"/"
)[0]
elif netbox_interface_name in transfer_ips:
elif transfer_ips and netbox_interface_name in transfer_ips:
local_ipv4 = transfer_ips[netbox_interface_name].split("/")[
0
]
Expand Down
Loading