tlshd: Release key and certs on QUIC client x509 setup failure#158
Merged
Merged
Conversation
When tlshd_x509_client_get_certs() or tlshd_x509_client_get_privkey() fails while preparing a QUIC client x509 session, the early return exits without releasing the module-global certificates and private key that were already loaded, leaking them. The TLS and QUIC server paths route such failures through their cleanup labels, which call the put_privkey() and put_certs() helpers; only the QUIC client path took a bare return. Route the failure through the cleanup path as the others do. Split the err: label so the configuration-failure path skips tlshd_log_gnutls_error(), which would otherwise read an uninitialized ret, and reaches only put_privkey() and put_certs() under a new err_config: label. Fixes: 43a15fe ("tlshd: add support for quic handshake") Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QUIC client x509 session setup returns early on a cert or private
key retrieval failure without releasing the certificates and key that
were already loaded into the module globals, leaking them.
This is the client-side counterpart to the QUIC server path fixed in
#157: route the failure through the cleanup label so it reaches
tlshd_x509_client_put_privkey() and tlshd_x509_client_put_certs(),
splitting the err: label so the configuration-failure path does not
log an uninitialized ret.