[AI-FSSDK] [FSSDK-12368] Remove legacy flag-level holdout fields#1146
Open
[AI-FSSDK] [FSSDK-12368] Remove legacy flag-level holdout fields#1146
Conversation
Remove deprecated includedFlags and excludedFlags from Holdout interface and simplify holdout handling to treat all holdouts as global. - Removed includedFlags and excludedFlags from Holdout interface - Removed includedHoldouts, excludedHoldouts, and globalHoldouts from ProjectConfig - Simplified _getHoldouts() method to return all holdouts - Removed getHoldoutsForFlag() method from ProjectConfig - Removed 3 test cases for deleted functionality - Updated remaining tests to use new global holdout behavior All 3079 tests pass. Verification: grep for includedFlags|excludedFlags returns 0 results. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated
includedFlagsandexcludedFlagsfrom Holdout interface and simplify holdout handling to treat all holdouts as global.Changes
includedFlagsandexcludedFlagsfrom Holdout interfaceincludedHoldouts,excludedHoldouts, andglobalHoldoutsfrom ProjectConfig_getHoldouts()method to return all holdoutsgetHoldoutsForFlag()method from ProjectConfigTesting
Quality Metrics
Related
🤖 Generated with Claude Code