Team dashboard: fire the GitHub activity check from the checklist too - #370
Merged
Merged
Conversation
The "Push code to your repo" checklist row reads the same GitHub activity as the Code activity card, but the fetch only fired when the card (bottom of the page) scrolled near — so the row sat on "Checking your repo's activity…" for anyone who stayed at #project. useGithubActivity now takes a ref or an array of refs and TeamDashboard observes both the DeliverablesChecklist and the CodeActivityCard; whichever comes near first fires the fire-once load. Pairs with the backend change that excludes the repo-bootstrap account's commits (GITHUB_ACTIVITY_EXCLUDED_LOGINS, default gregv) and reads the team doc fresh in get_team so the public team page reflects a story edit immediately. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "Push code to your repo" checklist row on
/hack/[event_id]/manageteamreads the same GitHub activity as the Code activity card, but the fetch only fired when the card (bottom of the page) scrolled near. Anyone who landed on#projectsaw "Checking your repo's activity…" indefinitely — nothing was checking.useGithubActivity(team, refOrRefs)now accepts a ref or an array of refs; the fire-onceIntersectionObserverobserves all of them and loads on the first to come near.TeamDashboardpasses[checklistRef, codeCardRef];DeliverablesChecklistexposes acontainerRefwrapper.Still fire-once, still ONE
setState, still no fetch inIN_REVIEW(neither element renders).Pairs with backend PR
opportunity-hack/backend-ohack.dev#287 (
fix/github-activity-exclusions-team-cache-cdn):get_repo_activitydrops commits by the repo-bootstrap account (GITHUB_ACTIVITY_EXCLUDED_LOGINS, defaultgregv) so a fresh repo reads "No commits yet" instead of "2 commits by gregv".get_teamreads the team doc fresh (per-worker cache could serve a stale project story for up to 10 min).cdn_server()so the thumbnail validator can't disagree with the upload route's URL prefix.This frontend PR is safe to deploy in either order; the backend PR is what changes the numbers.
Test plan
/hack/fall-2026/manageteam#project— stay at the top. The "Push code to your repo" row should resolve within a couple of seconds without scrolling (to "No commits yet" or "done"), never stuck on "Checking your repo's activity…"./api/github/activityfor the same repo (Network tab).github_links— row shows 🔒 "Repository not yet created"; card shows the "Repository not yet created" line; no GitHub calls.IN_REVIEWteam — hero + deadline strip + Slack + roster only; no/api/github/*requests.TeamSwitcher(if you have two) — the check re-runs for the new team's repos.🤖 Generated with Claude Code