Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
aliases:
srep-functional-team-aurora:
- AlexSmithGH
- BATMAN-JD
- dakotalongRH
- eth1030
- joshbranham
Expand Down
2 changes: 1 addition & 1 deletion boilerplate/_data/last-boilerplate-commit
Original file line number Diff line number Diff line change
@@ -1 +1 @@
61dbfdfcfd8ab11f8ccbd58bf1d299c2fa3336dd
c2342f1bcec55d87fd028e5c1d7f105c745eb32e
1 change: 1 addition & 0 deletions boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
aliases:
srep-functional-team-aurora:
- AlexSmithGH
- BATMAN-JD
- dakotalongRH
- eth1030
- joshbranham
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ WORKDIR ${OPERATOR_PATH}
# Build
RUN make go-build

FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778461551
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778562320
ENV OPERATOR_PATH=/gcp-project-operator \
OPERATOR_BIN=gcp-project-operator

Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile.olm-registry
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ COPY ${SAAS_OPERATOR_DIR} manifests
RUN initializer --permissive

# ubi-micro does not work for clusters with fips enabled unless we make OpenSSL available
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778461551
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1778562320

COPY --from=builder /bin/registry-server /bin/registry-server
COPY --from=builder /bin/grpc_health_probe /bin/grpc_health_probe
Expand Down
6 changes: 3 additions & 3 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
package config

const (
OperatorName string = "gcp-project-operator"
OperatorNamespace string = "gcp-project-operator"
EnableOLMSkipRange string = "true"
OperatorName string = "gcp-project-operator"
OperatorNamespace string = "gcp-project-operator"
EnableOLMSkipRange string = "true"
)
4 changes: 2 additions & 2 deletions controllers/projectclaim/projectclaim_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (r *ProjectClaimReconciler) Reconcile(ctx context.Context, req ctrl.Request

// Fetch the ProjectClaim instance
instance := &gcpv1alpha1.ProjectClaim{}
err := r.Get(context.TODO(), req.NamespacedName, instance)
err := r.Get(ctx, req.NamespacedName, instance)
if err != nil {
if errors.IsNotFound(err) {
// Request object not found, could have been deleted after reconcile request.
Expand All @@ -82,7 +82,7 @@ func (r *ProjectClaimReconciler) Reconcile(ctx context.Context, req ctrl.Request
}

conditionManager := condition.NewConditionManager()
adapter := NewProjectClaimAdapter(instance, reqLogger, r.Client, conditionManager)
adapter := NewProjectClaimAdapter(ctx, instance, reqLogger, r.Client, conditionManager)
result, err := r.ReconcileHandler(adapter)
reason := "ReconcileError"
_, _ = adapter.SetProjectClaimCondition(gcpv1alpha1.ConditionError, reason, err)
Expand Down
2 changes: 1 addition & 1 deletion controllers/projectclaim/projectclaim_fake.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
)

func (c *ProjectClaimAdapter) CreateFakeSecret() error {
if !gcputil.SecretExists(c.client, c.projectClaim.Spec.GCPCredentialSecret.Name, c.projectClaim.Spec.GCPCredentialSecret.Namespace) {
if !gcputil.SecretExists(c.ctx, c.client, c.projectClaim.Spec.GCPCredentialSecret.Name, c.projectClaim.Spec.GCPCredentialSecret.Namespace) {
privateKeyString, err := base64.StdEncoding.DecodeString("SS1hbS1mYWtlLXBhc3M=")
if err != nil {
return err
Expand Down
28 changes: 15 additions & 13 deletions controllers/projectclaim/projectclaimadapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ import (
)

type ProjectClaimAdapter struct {
projectClaim *gcpv1alpha1.ProjectClaim
projectClaim *gcpv1alpha1.ProjectClaim
ctx context.Context //nolint:containedctx

logger logr.Logger
client client.Client
projectReference *gcpv1alpha1.ProjectReference
Expand All @@ -40,9 +42,9 @@ const CCSSecretFinalizer string = "finalizer.gcp.managed.openshift.io/ccs" //#no
const RegionCheckFailed string = "RegionCheckFailed"
const FakeProjectClaim string = "managed.openshift.com/fake"

func NewProjectClaimAdapter(projectClaim *gcpv1alpha1.ProjectClaim, logger logr.Logger, client client.Client, manager condition.Conditions) *ProjectClaimAdapter {
func NewProjectClaimAdapter(ctx context.Context, projectClaim *gcpv1alpha1.ProjectClaim, logger logr.Logger, client client.Client, manager condition.Conditions) *ProjectClaimAdapter {
projectReference := newMatchingProjectReference(projectClaim)
return &ProjectClaimAdapter{projectClaim, logger, client, projectReference, manager}
return &ProjectClaimAdapter{projectClaim, ctx, logger, client, projectReference, manager}
}

// newMatchingProjectReference creates a ProjectReference CR from a ProjectClaim
Expand Down Expand Up @@ -74,7 +76,7 @@ func newMatchingProjectReference(projectClaim *gcpv1alpha1.ProjectClaim) *gcpv1a
// ProjectReferenceExists checks whether a matching ProjectReference already exists
func (c *ProjectClaimAdapter) ProjectReferenceExists() (bool, error) {
found := &gcpv1alpha1.ProjectReference{}
err := c.client.Get(context.TODO(), types.NamespacedName{Name: c.projectReference.Name, Namespace: c.projectReference.Namespace}, found)
err := c.client.Get(c.ctx, types.NamespacedName{Name: c.projectReference.Name, Namespace: c.projectReference.Namespace}, found)
if err != nil {
if errors.IsNotFound(err) {
return false, nil
Expand Down Expand Up @@ -140,7 +142,7 @@ func (c *ProjectClaimAdapter) deleteFinalizer(object client.Object, finalizer st
finalizers := metadata.GetFinalizers()
if gcputil.Contains(finalizers, finalizer) {
metadata.SetFinalizers(gcputil.Filter(finalizers, finalizer))
return c.client.Update(context.TODO(), object)
return c.client.Update(c.ctx, object)
}
return nil
}
Expand All @@ -154,7 +156,7 @@ func (c *ProjectClaimAdapter) FinalizeProjectClaim() (ObjectState, error) {

projectReferenceDeletionRequested := c.IsProjectReferenceDeletion()
if projectReferenceExists && !projectReferenceDeletionRequested {
err := c.client.Delete(context.TODO(), c.projectReference)
err := c.client.Delete(c.ctx, c.projectReference)
if err != nil {
return ObjectUnchanged, err
}
Expand Down Expand Up @@ -182,7 +184,7 @@ func (c *ProjectClaimAdapter) EnsureProjectClaimInitialized() (gcputil.Operation

if c.projectClaim.Status.Conditions == nil {
c.projectClaim.Status.Conditions = []gcpv1alpha1.Condition{}
err := c.client.Status().Update(context.TODO(), c.projectClaim)
err := c.client.Status().Update(c.ctx, c.projectClaim)
if err != nil {
return gcputil.RequeueWithError(operrors.Wrap(err, "failed to initialize projectclaim"))
}
Expand All @@ -201,7 +203,7 @@ func (c *ProjectClaimAdapter) EnsureProjectReferenceLink() (gcputil.OperationRes
return gcputil.ContinueProcessing()
}
c.projectClaim.Spec.ProjectReferenceCRLink = expectedLink
err := c.client.Update(context.TODO(), c.projectClaim)
err := c.client.Update(c.ctx, c.projectClaim)
if err != nil {
return gcputil.RequeueWithError(err)
}
Expand Down Expand Up @@ -241,7 +243,7 @@ func (c *ProjectClaimAdapter) addFinalizer(object client.Object, finalizer strin
finalizers := metadata.GetFinalizers()
if !gcputil.Contains(finalizers, finalizer) {
metadata.SetFinalizers(append(finalizers, finalizer))
return c.client.Update(context.TODO(), object)
return c.client.Update(c.ctx, object)
}
return nil
}
Expand All @@ -253,7 +255,7 @@ func (c *ProjectClaimAdapter) getCCSSecret() (*corev1.Secret, error) {
Namespace: c.projectClaim.Spec.CCSSecretRef.Namespace,
Name: c.projectClaim.Spec.CCSSecretRef.Name,
}
err := c.client.Get(context.TODO(), secretName, secret)
err := c.client.Get(c.ctx, secretName, secret)
if err != nil {
return nil, err
}
Expand All @@ -269,7 +271,7 @@ func (c *ProjectClaimAdapter) EnsureProjectReferenceExists() (gcputil.OperationR

if !projectReferenceExists {
return gcputil.RequeueOnErrorOrContinue(
c.client.Create(context.TODO(), c.projectReference))
c.client.Create(c.ctx, c.projectReference))
}
return gcputil.ContinueProcessing()
}
Expand Down Expand Up @@ -331,7 +333,7 @@ func (c *ProjectClaimAdapter) IsRegionSupported() (bool, error) {
return true, nil
}

operatorConfigMap, err := configmap.GetOperatorConfigMap(c.client)
operatorConfigMap, err := configmap.GetOperatorConfigMap(c.ctx, c.client)
if err != nil {
return true, operrors.Wrap(err, "could not find the OperatorConfigMap")
}
Expand Down Expand Up @@ -362,7 +364,7 @@ func (c *ProjectClaimAdapter) EnsureRegionSupported() (gcputil.OperationResult,

// StatusUpdate updates the project claim status
func (c *ProjectClaimAdapter) StatusUpdate() error {
if err := c.client.Status().Update(context.TODO(), c.projectClaim); err != nil {
if err := c.client.Status().Update(c.ctx, c.projectClaim); err != nil {
return operrors.Wrap(err, fmt.Sprintf("failed to update ProjectClaim state for %s", c.projectClaim.Name))
}

Expand Down
2 changes: 1 addition & 1 deletion controllers/projectclaim/projectclaimadapter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ var _ = Describe("Customresourceadapter", func() {
}
})
JustBeforeEach(func() {
adapter = NewProjectClaimAdapter(projectClaim, logf.Log.WithName("Test Logger"), mockClient, mockConditions)
adapter = NewProjectClaimAdapter(context.TODO(), projectClaim, logf.Log.WithName("Test Logger"), mockClient, mockConditions)
})

AfterEach(func() {
Expand Down
Loading