[release-4.20] OCPBUGS-85155: Backport GatewayAPIWithoutOLM feature gate as disabled#2871
Conversation
Add the GatewayAPIWithoutOLM feature gate to release-4.20 with all feature sets disabled. No behavioral change — the gate is present but OFF. Unblocks cleaner backports of noOLM-dependent code and tests. Cherry-picked from: a47ac12 openshift#2191 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Skipping CI for Draft Pull Request. |
|
Hello @gcs278! Some important instructions when contributing to openshift/api: |
|
@gcs278: This pull request references Jira Issue OCPBUGS-85149, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@gcs278: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I need to wait for an OCPBUGS (probably a backport of https://redhat.atlassian.net/browse/OCPBUGS-85149) or use NOJIRA for this - but still could be tagged otherwise. |
|
/lgtm @gcs278 valid bug and verified are for you to work out |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/refresh jira |
|
@gcs278: This pull request references Jira Issue OCPBUGS-85155, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary
Backport the
GatewayAPIWithoutOLMfeature gate definition to release-4.20 with all feature sets disabled. The gate is present but OFF — no behavioral change.Why
Unblocks test backports — test backports that reference the
GatewayAPIWithoutOLMfeature gate need the gate definition to exist so they can compile. Without it, any noOLM-dependent test backport to 4.20 will fail.Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.20 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.
Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.
Changes
FeatureGateGatewayAPIWithoutOLMtofeatures/features.gowith noenableIncall (disabled everywhere)Mirror of #2864 (release-4.21)