TEST: CI validation with debug print statements (DO NOT MERGE)#110
TEST: CI validation with debug print statements (DO NOT MERGE)#110siddardh-ra wants to merge 1 commit into
Conversation
Add test echo statements to validate CI is running from PR branch: - Print script start time and git branch/commit info - Print deployment version and build type details - Print completion messages for downstream/upstream deployments - Print final completion message This is a test PR to validate the CI changes merged in openshift/release#81184. These print statements will NOT be merged. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: siddardh-ra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request adds several diagnostic echo statements to the ci-scripts/setup-cluster.sh script to trace execution progress, current git branch, and commit. The reviewer pointed out a critical issue where git rev-parse HEAD could fail and prematurely terminate the script due to set -o errexit if git is not installed or if the script is run outside of a git repository, and provided a safe fallback suggestion.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| echo "===== TEST: Script directory is $(dirname "$0") =====" | ||
| echo "===== TEST: Current git branch is $(git branch --show-current 2>/dev/null || echo 'detached HEAD') =====" | ||
| echo "===== TEST: Current git commit is $(git rev-parse HEAD) =====" |
There was a problem hiding this comment.
Since set -o errexit is enabled, if this script is executed in an environment where git is not installed or outside of a git repository, git rev-parse HEAD will fail and cause the entire script to terminate immediately. Guard the command with a fallback to prevent unexpected failures.
| echo "===== TEST: Current git commit is $(git rev-parse HEAD) =====" | |
| echo "===== TEST: Current git commit is $(git rev-parse HEAD 2>/dev/null || echo 'unknown') =====" |
|
/test ? |
|
/test max-concurrency-downstream-1-20-1000-x-math-qbt |
Add test echo statements to validate CI is running from PR branch:
This is a test PR to validate the CI changes merged in openshift/release#81184. These print statements will NOT be merged.