Skip to content

TEST: CI validation with debug print statements (DO NOT MERGE)#110

Open
siddardh-ra wants to merge 1 commit into
openshift-pipelines:mainfrom
siddardh-ra:test-ci-validation-print-statements
Open

TEST: CI validation with debug print statements (DO NOT MERGE)#110
siddardh-ra wants to merge 1 commit into
openshift-pipelines:mainfrom
siddardh-ra:test-ci-validation-print-statements

Conversation

@siddardh-ra

Copy link
Copy Markdown
Collaborator

Add test echo statements to validate CI is running from PR branch:

  • Print script start time and git branch/commit info
  • Print deployment version and build type details
  • Print completion messages for downstream/upstream deployments
  • Print final completion message

This is a test PR to validate the CI changes merged in openshift/release#81184. These print statements will NOT be merged.

Add test echo statements to validate CI is running from PR branch:
- Print script start time and git branch/commit info
- Print deployment version and build type details
- Print completion messages for downstream/upstream deployments
- Print final completion message

This is a test PR to validate the CI changes merged in
openshift/release#81184. These print statements will NOT be merged.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from jhutar and khrm June 29, 2026 07:51
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: siddardh-ra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@siddardh-ra siddardh-ra changed the title TEST: Add debug print statements for CI validation TEST: CI validation with debug print statements (DO NOT MERGE) Jun 29, 2026
@siddardh-ra siddardh-ra self-assigned this Jun 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several diagnostic echo statements to the ci-scripts/setup-cluster.sh script to trace execution progress, current git branch, and commit. The reviewer pointed out a critical issue where git rev-parse HEAD could fail and prematurely terminate the script due to set -o errexit if git is not installed or if the script is run outside of a git repository, and provided a safe fallback suggestion.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.


echo "===== TEST: Script directory is $(dirname "$0") ====="
echo "===== TEST: Current git branch is $(git branch --show-current 2>/dev/null || echo 'detached HEAD') ====="
echo "===== TEST: Current git commit is $(git rev-parse HEAD) ====="

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Since set -o errexit is enabled, if this script is executed in an environment where git is not installed or outside of a git repository, git rev-parse HEAD will fail and cause the entire script to terminate immediately. Guard the command with a fallback to prevent unexpected failures.

Suggested change
echo "===== TEST: Current git commit is $(git rev-parse HEAD) ====="
echo "===== TEST: Current git commit is $(git rev-parse HEAD 2>/dev/null || echo 'unknown') ====="

@siddardh-ra

Copy link
Copy Markdown
Collaborator Author

/test ?

@siddardh-ra

Copy link
Copy Markdown
Collaborator Author

/test max-concurrency-downstream-1-20-1000-x-math-qbt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant