Include inherited ServiceNow table fields in field lookup#2312
Merged
Conversation
Walk the sys_db_object hierarchy and merge sys_dictionary entries so child tables like incident expose parent table fields in dropdowns. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ServiceNow dictionary field lookup to include inherited fields by walking the sys_db_object table inheritance chain, so child tables (e.g. incident) surface parent fields in mapping dropdowns.
Changes:
- Add
sys_db_objectlookups to build a table hierarchy (child → parent → …). - Query
sys_dictionaryfor all tables in that hierarchy and merge/deduplicate fields byelement, preferring the most specific table. - Increase
sys_dictionaryfetch limit to accommodate the expanded query set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ravikiranvm
commented
May 29, 2026
| const tables = await getServiceNowTables(auth as ServiceNowAuth, { | ||
| query: 'nameSTARTSWITHx_', | ||
| }); | ||
| const tables = await getServiceNowTables(auth as ServiceNowAuth); |
Contributor
Author
There was a problem hiding this comment.
This reverts the change committed in https://github.com/openops-cloud/openops/pull/2259/changes#diff-46cca212ec4c6c22b05d80a485896ee77a3eae825266ba8f602e1d8e27248b8cL24. This fixes the tables dropdown issue and fixes OPS-4431
ravikiranvm
commented
May 29, 2026
| try { | ||
| tableNames = await getServiceNowTableHierarchy(auth, tableName); | ||
| } catch (error) { | ||
| tableNames = [tableName]; |
Contributor
Author
There was a problem hiding this comment.
Marco is not sure yet of what table would we have permissions for.
So if the user doesn't have permission to the 'sys_db_object', we fall-back to the original approach.
ravikiranvm
commented
May 29, 2026
| fieldName: Property.StaticDropdown<string>({ | ||
| displayName: 'Field name', | ||
| description: | ||
| 'Includes inherited fields from parent tables if your account has read access to sys_db_object.', |
Contributor
Author
There was a problem hiding this comment.
This is to let user know if he is confused about the missing fields.
ravikiranvm
added a commit
that referenced
this pull request
Jun 1, 2026
- Move getServiceNowChoiceValues / ServiceNowChoice from the ServiceNow block into @openops/common so it can be reused across packages. The blocks-level file is removed and its single consumer (create-field-value-property) now imports from @openops/common. - Add getServiceNowStateFields, a helper that returns the columns on a given table (including parent-table columns) that are usable as a status field (choice or integer with a layered sys_choice list). This is needed by upcoming campaign features that let users pick which ServiceNow field to read ticket state from. Stacked on top of #2312 because getServiceNowStateFields depends on the parent-hierarchy walk added there. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ravikiranvm
added a commit
that referenced
this pull request
Jun 1, 2026
- Move getServiceNowChoiceValues / ServiceNowChoice from the ServiceNow block into @openops/common so it can be reused across packages. The blocks-level file is removed and its single consumer (create-field-value-property) now imports from @openops/common. - Add getServiceNowStateFields, a helper that returns the columns on a given table (including parent-table columns) that are usable as a status field (choice or integer with a layered sys_choice list). This is needed by upcoming campaign features that let users pick which ServiceNow field to read ticket state from. Stacked on top of #2312 because getServiceNowStateFields depends on the parent-hierarchy walk added there. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
MarceloRGonc
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-4414 and OPS-4431
Problem
I was not able to see some service now table fields like
DescriptionandShort Description. It was due to that these fields were inherited from parent tables and we were looking for only the fields defined in the given table.ServiceNow doesn't have an endpoint to return all the table fields their UI shows. There is one undocumented endpoint that returns all table fields that are shown on ServiceNow UI
/ui/meta/{table}. But it is not officially available in their docs.The current PR approach is how people usually solve this problem. Look ServiceNow REST API: Get list of column names
Fix
sys_db_objecttable hierarchy (the table of all tables in SN) when loading dictionary fieldsincident) expose fields likedescription