Improve workflow failure logging and remove console logs#2309
Merged
Conversation
MarceloRGonc
changed the title
MarceloRGonc
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR (part of OPS-4415) replaces scattered console.* statements with the shared structured logger and adds additional engine/workflow context to improve failure diagnostics and log correlation.
Changes:
- Replace
console.*calls across engine, worker, and blocks with@openops/server-sharedlogger. - Prevent worker from overwriting a flow run’s status if the run is already terminal.
- Enrich engine operation completion logs and engine log context fields.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/server/worker/src/lib/executors/flow-job-executor.ts | Avoid updating run status when the run is already terminal after an engine failure. |
| packages/openops/src/lib/aws/tags/tag-resources.ts | Replace console logging with structured logger when AWS tagging fails. |
| packages/engine/src/lib/variables/processors/json.ts | Replace console.error with structured warning log on JSON parse failure. |
| packages/engine/src/lib/variables/processors/file.ts | Replace console.error with structured warning log on file decode/load failure. |
| packages/engine/src/lib/variables/processors/date-time.ts | Replace console.error with structured warning log on date-time processing failure. |
| packages/engine/src/lib/helper/trigger-helper.ts | Replace console logs with structured logs for trigger hooks and webhook verification. |
| packages/engine/src/lib/helper/block-helper.ts | Replace console error with structured warning for property execution failures. |
| packages/engine/src/lib/handler/context/engine-constants.ts | Append project display name into async log context for engine executions. |
| packages/engine/src/lib/handler/branch-executor.ts | Replace console error with structured warning on branch execution failures. |
| packages/engine/src/engine-executor.ts | Enrich “finished operation” log payload and add hasOperationStatus helper. |
| packages/engine/src/api-handler.ts | Update log context fields and adjust error logging call shape. |
| packages/blocks/text-helper/src/lib/actions/markdown-to-html.ts | Remove stray console.log debug output. |
| packages/blocks/schedule/src/lib/triggers/every-x-minutes.trigger.ts | Replace console.log with structured debug log on disable. |
| packages/blocks/schedule/src/lib/triggers/every-week.trigger.ts | Replace console.log with structured debug log on disable. |
| packages/blocks/schedule/src/lib/triggers/every-month.trigger.ts | Replace console.log with structured debug log on disable. |
| packages/blocks/schedule/src/lib/triggers/every-hour.trigger.ts | Replace console.log with structured debug log on disable. |
| packages/blocks/schedule/src/lib/triggers/every-day.trigger.ts | Replace console.log with structured debug log on disable. |
| packages/blocks/schedule/src/lib/triggers/cron-expression.trigger.ts | Replace console.log with structured debug log on disable. |
| packages/blocks/monday/src/lib/common/index.ts | Replace console.debug with structured debug log on board column load failure. |
| packages/blocks/microsoft-outlook/src/lib/actions/reply-email.ts | Replace console error with structured error log when replying fails. |
| packages/blocks/linear/src/lib/triggers/updated-issue.ts | Replace console error with structured error log when webhook creation fails. |
| packages/blocks/linear/src/lib/triggers/removed-issue.ts | Replace console error with structured error log when webhook creation fails. |
| packages/blocks/linear/src/lib/triggers/new-issue.ts | Replace console error with structured error log when webhook creation fails. |
| packages/blocks/date-helper/src/lib/actions/next-day-of-week.ts | Remove stray console.log debug output. |
| packages/blocks/common/src/lib/http/axios/axios-http-client.ts | Replace console error logging with structured error log on request failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ravikiranvm
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OPS-4415