test: update psqlreplicatests#307
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdds a PostgreSQL replica container helper, updates integration tests to use real containers, removes the static replica config, and broadens Sonar coverage exclusions. ChangesReplica test helper and integration coverage
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e0bfe54 to
d8c6d61
Compare
|
@coderabbitai summary |
✅ Action performedSummary regeneration triggered. |
f356d7c to
2c638a6
Compare
|
Honestly speaking I dont see much value in this tests. This seems to be testing GORM DBResolver and not anything implemented by us |
2c638a6 to
325f2ac
Compare
|
@coderabbitai summary |
✅ Action performedSummary regeneration triggered. |
Good catch — dropped the GORM/dbresolver tests, suite now covers only db.StartDBConnection paths plus fixture sanity checks. |
I might be missing something, but all of these tests that currently exist are testing the GORM DbResolver. We don't have anything implemented by us for DB Replication. All of those checking if the replicas work are testing GORM. IMO none of these tests are really needed. The only code that this runs that could possibly cause issues is the OpenConnection that is not related with any Replication Also, as a side note, I'm not entirely sure if we even use Replication at this level at all. I might be mistaken but we have a proxy on the DB that handles all of that internally, so we don't really ever use the DB Replicas |
dca1740 to
02a90c6
Compare
|
@coderabbitai summary |
✅ Action performedSummary regeneration triggered. |
jmpTeixeira02
left a comment
There was a problem hiding this comment.
Overall looking cleaner
02a90c6 to
5d66987
Compare
Signed-off-by: Niaz Khan <niazkhansap@gmail.com>
Signed-off-by: Niaz Khan <niazkhansap@gmail.com>
5d66987 to
3c185d2
Compare
No description provided.