8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared#4534
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared. This is a test fix. For parity with Oracle JDK. |
Backporting JDK-8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared.
This PR fixes test by simplifying reference chains and disabling ScavengeBeforeFullGC.
This PR isn't clean because the test didn't need to be removed from the problem list.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/vmTestbase/gc/gctests/WeakReference/weak006/weak006.java
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4534/head:pull/4534$ git checkout pull/4534Update a local copy of the PR:
$ git checkout pull/4534$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4534/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4534View PR using the GUI difftool:
$ git pr show -t 4534Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4534.diff
Using Webrev
Link to Webrev Comment