Skip to content

8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared#4534

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8286737-V17
Open

8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared#4534
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8286737-V17

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared.

This PR fixes test by simplifying reference chains and disabling ScavengeBeforeFullGC.

This PR isn't clean because the test didn't need to be removed from the problem list.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/vmTestbase/gc/gctests/WeakReference/weak006/weak006.java

Results:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8286737 needs maintainer approval

Issue

  • JDK-8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4534/head:pull/4534
$ git checkout pull/4534

Update a local copy of the PR:
$ git checkout pull/4534
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4534

View PR using the GUI difftool:
$ git pr show -t 4534

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4534.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 22, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 22, 2026

Copy link
Copy Markdown

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 6a33974a6b8a629744c6d76c3b4fa1f772e52ac8 8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared Jun 22, 2026
@openjdk

openjdk Bot commented Jun 22, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label Jun 22, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review June 22, 2026 13:59
@openjdk openjdk Bot added the rfr Pull request is ready for review label Jun 22, 2026
@mlbridge

mlbridge Bot commented Jun 22, 2026

Copy link
Copy Markdown

Webrevs

@openjdk

openjdk Bot commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@rm-gh-8

rm-gh-8 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8286737: Test vmTestbase/gc/gctests/WeakReference/weak006/weak006.java fails: Last soft reference has not been cleared.

This is a test fix.

For parity with Oracle JDK.

@openjdk

openjdk Bot commented Jun 22, 2026

Copy link
Copy Markdown

@rm-gh-8
8286737: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants