chore: upgrade python requirements and fix isort invocation - #389
Merged
Conversation
isort's --recursive flag has been deprecated and a no-op for a long time. It's finally a fatal error, forcing us to remove it.
pwnage101
enabled auto-merge
August 31, 2026 22:29
pwnage101
commented
Aug 31, 2026
| pycodestyle openedx_filters *.py | ||
| ruff check openedx_filters *.py | ||
| isort --check-only --diff --recursive test_utils openedx_filters *.py test_settings.py | ||
| isort --check-only --diff test_utils openedx_filters *.py |
Contributor
Author
There was a problem hiding this comment.
This is the only line I changed manually.
felipemontoya
approved these changes
Aug 31, 2026
felipemontoya
left a comment
felipemontoya
left a comment
Member
There was a problem hiding this comment.
Found this in a different repo I also maintain. This looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isort's--recursiveflag has been deprecated and a no-op for a long time. It's finally a fatal error, forcing us to remove it.This also removes the "test_settings.py" arg which points to a file which doesn't exist anymore.
This also contains the result of
make upgrade.Note for reviewers: This does NOT need a version bump because it results in no change to the published package.