feat(httproute): add optional kind and group fields to parentRefs

[pierre-jezegou]

Add kind and group to HTTPRoute parentRefs

Required to support ListenerSet as a parent resource for HTTPRoute, promoted to Standard channel in Gateway API v1.5
See https://gateway-api.sigs.k8s.io/guides/listener-set/

Changes

• Add optional kind and group fields in httproute.yaml (ui, api, mcp)
• Add them as commented fields in values.yaml (defaults to kind: Gateway)

[Copilot]

Pull request overview

Adds support for Gateway API v1.5 ListenerSet (and other non-default parent resources) by allowing kind and group to be specified on HTTPRoute.spec.parentRefs in the OpenCost Helm chart.

Changes:

• Extend HTTPRoute templates to optionally render parentRefs[].kind and parentRefs[].group for UI, API, and MCP HTTPRoutes.
• Document the new optional kind/group fields in values.yaml under each HTTPRoute’s parentRefs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
charts/opencost/values.yaml	Documents optional kind and group fields for httpRoute.parentRefs in UI/API/MCP values.
charts/opencost/templates/httproute.yaml	Renders optional kind/group fields into HTTPRoute.spec.parentRefs for UI/API/MCP routes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ameijer]

@pierre-jezegou looks like some decent copilot findings, could you remediate?

[ameijer]

and please bump the patch version on the chart

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (4)

charts/opencost/templates/httproute.yaml:73

• The {{ if .kind }} / {{ end }} and {{ if .group }} / {{ end }} blocks don’t use whitespace-trimming ({{- ... }}), which will emit whitespace-only lines in the rendered manifest. With the repo’s yamllint config enabling trailing-spaces, these space-only lines can cause ct lint to fail. Use trimmed control tags ({{- if ... }} / {{- end }}) consistent with the existing namespace/sectionName blocks so no trailing-space lines are rendered.

      {{ if .kind }}
      kind: {{ .kind | quote }}
      {{ end }}
      {{ if .group }}
      group: {{ .group | quote }}
      {{ end }}

charts/opencost/templates/httproute.yaml:123

• The {{ if .kind }} / {{ end }} and {{ if .group }} / {{ end }} blocks don’t use whitespace-trimming ({{- ... }}), which will emit whitespace-only lines in the rendered manifest. With the repo’s yamllint config enabling trailing-spaces, these space-only lines can cause ct lint to fail. Use trimmed control tags ({{- if ... }} / {{- end }}) consistent with the existing namespace/sectionName blocks so no trailing-space lines are rendered.

      {{ if .kind }}
      kind: {{ .kind | quote }}
      {{ end }}
      {{ if .group }}
      group: {{ .group | quote }}
      {{ end }}

charts/opencost/values.yaml:456

• These commented examples show kind/group as empty strings, but the PR description says the defaults are kind: Gateway (and default group implied by Gateway API). Using "" here is misleading for users copying the example; consider updating the commented example to show the actual defaults (or explicitly document that omitting the fields uses the Gateway API defaults).

          # kind: ""
          # group: ""

charts/opencost/values.yaml:759

• These commented examples show kind/group as empty strings, but the PR description says the defaults are kind: Gateway (and default group implied by Gateway API). Using "" here is misleading for users copying the example; consider updating the commented example to show the actual defaults (or explicitly document that omitting the fields uses the Gateway API defaults).

          # kind: ""
          # group: ""

[thomasvn]

@pierre-jezegou Agree with this, we should whitespace trim similar to how the rest of the template does.

[thomasvn]

That default is not determined by this Helm chart. Closing comment.

[thomasvn]

Although we shouldn't set the default ourselves in the values.yaml. A comment here may help users? @pierre-jezegou?

parentRefs:
  - name: ""
    # kind: "Gateway"  # Default when omitted
    # group: "gateway.networking.k8s.io"  # Default when omitted