Skip to content

Clarify trigger semantics for pipeline-errors 'threshold' and 'active'#1494

Open
earies wants to merge 1 commit into
openconfig:masterfrom
earies:pipeline-counters-threshold
Open

Clarify trigger semantics for pipeline-errors 'threshold' and 'active'#1494
earies wants to merge 1 commit into
openconfig:masterfrom
earies:pipeline-counters-threshold

Conversation

@earies

@earies earies commented May 13, 2026

Copy link
Copy Markdown
Contributor
  • (M) release/models/platform/openconfig-platform-pipeline-counters.yang
    • Clarify trigger semantics for 'threshold' and 'active'
    • Increment to version 0.6.1

Change Scope

Clarify the trigger semantics shared by pipeline-errors-common threshold and
active leafs. Documentation only change, no schema changes.

Platform Implementations

N/A

Tree View

No tree updates were made as part of this patchset.

@earies earies requested a review from a team as a code owner May 13, 2026 15:44

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the openconfig-platform-pipeline-counters YANG model to version 0.5.2. It adds a new revision entry and provides clearer descriptions for the threshold and active leaves regarding their trigger and transition semantics. A review comment correctly identifies that the revision date is set to a future date and should be corrected.

Comment thread release/models/platform/openconfig-platform-pipeline-counters.yang Outdated
@dplore dplore moved this to Ready to discuss in OC Operator Review May 15, 2026
@dplore

dplore commented May 15, 2026

Copy link
Copy Markdown
Member

/gcbrun

@OpenConfigBot

OpenConfigBot commented May 15, 2026

Copy link
Copy Markdown

No major YANG version changes in commit cbfc9b4

@navaneethyv

Copy link
Copy Markdown
Contributor

OC Review June 2nd.

There is an conflicting change that has bumped up the version of the yang file to 6.0, please make the version change into 6.1 after re basing to latest master for us to take it further.

@navaneethyv

Copy link
Copy Markdown
Contributor

OC operator review June 23.

@earies could you take care of the conflict ? We can take this to closure right after that.

  * (M) release/models/platform/openconfig-platform-pipeline-counters.yang
    - Clarify trigger semantics for 'threshold' and 'active'
    - Increment to version 0.5.2
@earies earies force-pushed the pipeline-counters-threshold branch from 9987b23 to cbfc9b4 Compare June 23, 2026 18:56
@earies

earies commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

OC operator review June 23.

@earies could you take care of the conflict ? We can take this to closure right after that.

ack - branch is up to date and conflict resolved

@navaneethyv

Copy link
Copy Markdown
Contributor

/gcbrun

@navaneethyv navaneethyv moved this from Ready to discuss to last-call in OC Operator Review Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: last-call

Development

Successfully merging this pull request may close these issues.

4 participants