fix: getTunnelTargetMatch never reports a match#885
Open
zentavr wants to merge 1 commit into
Open
Conversation
The store.List filter closure in getTunnelTargetMatch checked the target ID regex, the target Type regex, and computed the resulting TargetConfig, but every code path fell through to the unconditional `return false` at the end of the function. As a result store.List never included any entry in its result, matchingConfigs was always empty, and getTunnelTargetMatch always returned nil -- so every connecting tunnel target was rejected with "target ignored, not matching any rule" regardless of any configured tunnel-target-matches. This has been broken since the tunnel-target-matches feature was introduced in 7e297f7. Add a regression test that fails on the old code and passes with the fix.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #884
getTunnelTargetMatch's filter closure (passed tostore.List) checks the target ID regex,Type regex, and builds the resulting
TargetConfig- but every branch, including thesuccessful match, fell through to the unconditional
return falseat the end of the function.store.Listonly includes an entry when the filter returnstrue, somatchingConfigswasalways empty and every tunnel target was rejected as
"target ignored, not matching any rule",regardless of configuration.
This has been broken since the
tunnel-target-matchesfeature was added in 7e297f7.return trueon the successful match path.tunnel_server_test.go) that fails against the old code and passeswith the fix.