be smarter when assembling the constraints expression#281
Merged
Conversation
1 task
There was a problem hiding this comment.
Pull request overview
This PR optimizes how Constraint.expression is assembled in the matrix-based interfaces (used by the hybrid solver), avoiding per-constraint iteration over every model variable by instead constructing expressions only from non-zero stored coefficients. It also fixes a local typo in the objective parsing code path.
Changes:
- Build
Constraint.expressionfrom the sparse(constraint, variable) -> coefficientmapping instead of scanning all variables. - Fix typo
quadratic_coeffients→quadratic_coefficientsin the objective setter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
oxinabox
approved these changes
May 28, 2026
oxinabox
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me.
I can't test it.
Because versioneer on this branch thinks it is v2.dev
and so pip refuses to install the branch.
(If this isn't merged/tagged by time i start work tomorrow, I will hack around it, and test it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assembling
Constraint.expressionthe matrix interface would iterate over all variables for each constraint. Now it prefilters the coefficients and only uses the relevant variables making the expression sparse as it should be.Also fixed a typo.