Repository navigation
feat(meet): add recording, transcription, and moderation flags - #1182
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 7, 2026, 12:47 AM ET / 04:47 UTC (Revision 4). ClawSweeper reviewWhat this changesAdds Google Meet create/update flags for recording, transcription, smart notes, attendance reports, and moderation, with precise updates, settings output, documentation, and regression coverage. Merge readiness✅ Ready for maintainer review This PR remains useful: main and v0.43.0 lack the requested settings. The prior contributor-credit finding is resolved, and no new blocking defect was established. Priority: P2 Review scores
Verification
How this fits togetherThe Meet commands translate CLI settings into authenticated Google Meet API requests. Google applies the configuration and returns meeting settings for JSON or text output. flowchart LR
A[CLI settings] --> B[Validate explicit flags]
B --> C[Configuration and field mask]
D[Account credentials] --> E[Google Meet API]
C --> E
E --> F[Meeting settings]
F --> G[JSON or text output]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep the additive settings on the existing Meet commands, preserving omitted values through individual field masks. Do we have a high-confidence way to reproduce the issue? Not applicable to an existing-behavior bug; source establishes the missing CLI settings, and retained live evidence covers their new behavior. Is this the best way to solve the issue? Yes. Shared optional flags and precise field masks extend the existing commands without a competing configuration path or changes to omitted settings. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 0cd6ccf6d9ce. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles)
|
8c018a1 to
b37c27a
Compare
|
@steipete heads up, the only thing ClawSweeper still flags is the "thanks" line in |
Expose explicit settings flags with precise update masks and preserve omitted configuration. Include regression coverage, command documentation, and contributor-provided live Workspace evidence in PR openclaw#1182. Co-authored-by: Dan Wager <danielwager@gmail.com>
b37c27a to
c642f80
Compare
|
Landed with contributor credit and a credited Unreleased entry. The final candidate passed the full Exact-head CI at The implementation preserves omitted settings, uses individual update masks, and rejects conflicting moderation options before authentication. Live Workspace/consumer behavior evidence is the contributor-provided proof summarized in the PR; the live meeting session was not repeated during this landing. Thanks @regaw-leinad. |
Meet creation and updates previously exposed access settings but not recording, transcription, notes, attendance, or moderation. Add explicit positive/negative flags for those existing SpaceConfig fields and show returned settings in text output.
Omitted flags preserve account defaults on create and current values on update. Updates use individual field masks, so changing one setting leaves the others alone. Restriction flags enable moderation; combining them with
--no-moderationfails before authentication. Dry runs show the exact configuration and mask. No new OAuth scope is requested.Contributor-provided live proof covered Workspace and consumer accounts: creating a meeting with recording/transcription/smart notes enabled; disabling recording while keeping the other settings; moderation/viewer restrictions; updating a Calendar-created Meet link; and the provider rejecting unavailable account features. The contributor also confirmed automatic recording/transcription when an eligible organizer joined. This round reviewed that supplied evidence rather than repeating the live meeting session.
Tests cover every flag in both directions, omission, combined masks, invalid moderation combinations, dry runs, and text output. Documentation and the live-test script cover the new flags. Thanks @regaw-leinad for the implementation and live proof.
Maintainer validation on the rebased candidate: full
make cion AWS Crabbox and independent Codex review through P2 passed. The Unreleased entry credits the contributor.