Skip to content

feat(meet): add recording, transcription, and moderation flags - #1182

Merged
steipete merged 1 commit into
openclaw:mainfrom
regaw-leinad:feat/meet-space-config
Oct 7, 2026
Merged

steipete merged 1 commit into
openclaw:mainfrom
regaw-leinad:feat/meet-space-config

Conversation

@regaw-leinad

@regaw-leinad regaw-leinad commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Meet creation and updates previously exposed access settings but not recording, transcription, notes, attendance, or moderation. Add explicit positive/negative flags for those existing SpaceConfig fields and show returned settings in text output.

Omitted flags preserve account defaults on create and current values on update. Updates use individual field masks, so changing one setting leaves the others alone. Restriction flags enable moderation; combining them with --no-moderation fails before authentication. Dry runs show the exact configuration and mask. No new OAuth scope is requested.

Contributor-provided live proof covered Workspace and consumer accounts: creating a meeting with recording/transcription/smart notes enabled; disabling recording while keeping the other settings; moderation/viewer restrictions; updating a Calendar-created Meet link; and the provider rejecting unavailable account features. The contributor also confirmed automatic recording/transcription when an eligible organizer joined. This round reviewed that supplied evidence rather than repeating the live meeting session.

Tests cover every flag in both directions, omission, combined masks, invalid moderation combinations, dry runs, and text output. Documentation and the live-test script cover the new flags. Thanks @regaw-leinad for the implementation and live proof.

Maintainer validation on the rebased candidate: full make ci on AWS Crabbox and independent Codex review through P2 passed. The Unreleased entry credits the contributor.

@clawsweeper

clawsweeper Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 1, 2026
@clawsweeper

clawsweeper Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed October 7, 2026, 12:47 AM ET / 04:47 UTC (Revision 4).

ClawSweeper review

What this changes

Adds Google Meet create/update flags for recording, transcription, smart notes, attendance reports, and moderation, with precise updates, settings output, documentation, and regression coverage.

Merge readiness

✅ Ready for maintainer review

This PR remains useful: main and v0.43.0 lack the requested settings. The prior contributor-credit finding is resolved, and no new blocking defect was established.

Priority: P2
Reviewed head: c642f804a241994784ae7d7c51d4be1a3d6471ed

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused extension with retained sufficient live proof, precise updates, useful regression coverage, and the earlier credit finding resolved.
Proof confidence 🐚 platinum hermit (4/6) Sufficient (terminal): Retained terminal-proof assessment and the captured maintainer validation cover the changed Meet create/update path: artifact creation, narrow updates preserving unrelated settings, viewer moderation, account-specific rejection, and organizer-triggered recording/transcription. This review did not repeat the live session or inspect the original terminal transcript, which is no longer embedded in the body. No stored-data format changes; optional fields and individual masks preserve existing settings.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Verified Sufficient (terminal): Retained terminal-proof assessment and the captured maintainer validation cover the changed Meet create/update path: artifact creation, narrow updates preserving unrelated settings, viewer moderation, account-specific rejection, and organizer-triggered recording/transcription. This review did not repeat the live session or inspect the original terminal transcript, which is no longer embedded in the body. No stored-data format changes; optional fields and individual masks preserve existing settings.
Evidence reviewed 9 items Repository policy: Read the full root AGENTS.md and checked the touched subtrees; no nested AGENTS.md or maintainer-notes directory was found. Applied review-only handling, parseable output guidance, and contributor-credit requirements.
Introduced implementation: Read the complete pinned introduction diff and production call sites. Optional boolean pointers omit unset fields, update masks target individual settings, and restriction changes enable moderation while rejecting conflicting flags before authentication.
Still necessary: Current main exposes access and entry-point settings without the new configuration flags. The inspected v0.43.0 update command also lacks them; the canonical search did not establish a replacement fixing PR.
Findings None None.
Security None None.

How this fits together

The Meet commands translate CLI settings into authenticated Google Meet API requests. Google applies the configuration and returns meeting settings for JSON or text output.

flowchart LR
 A[CLI settings] --> B[Validate explicit flags]
 B --> C[Configuration and field mask]
 D[Account credentials] --> E[Google Meet API]
 C --> E
 E --> F[Meeting settings]
 F --> G[JSON or text output]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Net code growth production +163 lines; tests +285 lines; live-test script +3 lines Production growth implements nine shared settings and output handling, with focused coverage for masks, flag directions, and validation.

Technical review

Best possible solution:

Keep the additive settings on the existing Meet commands, preserving omitted values through individual field masks.

Do we have a high-confidence way to reproduce the issue?

Not applicable to an existing-behavior bug; source establishes the missing CLI settings, and retained live evidence covers their new behavior.

Is this the best way to solve the issue?

Yes. Shared optional flags and precise field masks extend the existing commands without a competing configuration path or changes to omitted settings.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 0cd6ccf6d9ce.

Labels

Label changes:

No label changes.

Label justifications:

  • P2: This is a bounded Meet capability expansion that preserves existing defaults and has recorded live validation.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (terminal): Retained terminal-proof assessment and the captured maintainer validation cover the changed Meet create/update path: artifact creation, narrow updates preserving unrelated settings, viewer moderation, account-specific rejection, and organizer-triggered recording/transcription. This review did not repeat the live session or inspect the original terminal transcript, which is no longer embedded in the body. No stored-data format changes; optional fields and individual masks preserve existing settings.
  • proof: sufficient: Contributor real behavior proof is sufficient. Retained terminal-proof assessment and the captured maintainer validation cover the changed Meet create/update path: artifact creation, narrow updates preserving unrelated settings, viewer moderation, account-specific rejection, and organizer-triggered recording/transcription. This review did not repeat the live session or inspect the original terminal transcript, which is no longer embedded in the body. No stored-data format changes; optional fields and individual masks preserve existing settings.

Evidence

What I checked:

  • Repository policy: Read the full root AGENTS.md and checked the touched subtrees; no nested AGENTS.md or maintainer-notes directory was found. Applied review-only handling, parseable output guidance, and contributor-credit requirements. (AGENTS.md:46, c642f804a241)
  • Introduced implementation: Read the complete pinned introduction diff and production call sites. Optional boolean pointers omit unset fields, update masks target individual settings, and restriction changes enable moderation while rejecting conflicting flags before authentication. (internal/cmd/meet_config.go:28, c642f804a241)
  • Still necessary: Current main exposes access and entry-point settings without the new configuration flags. The inspected v0.43.0 update command also lacks them; the canonical search did not establish a replacement fixing PR. (internal/cmd/meet_update_end.go:14, 3b5122f4c81c)
  • Prior finding resolved: The Unreleased entry now includes contributor thanks, satisfying the concrete finding and rank-up move retained from the previous review. The contributor's earlier comment explicitly left that credit for landing: feat(meet): add recording, transcription, and moderation flags #1182 (comment). (CHANGELOG.md:5, c642f804a241)
  • Retained live behavior proof: The captured body records contributor live Workspace and consumer-account validation of creation, artifact updates preserving unrelated settings, moderation/viewer restrictions, Calendar-created links, provider rejection, and automatic recording/transcription after an eligible organizer joined. The earlier completed review explicitly assessed Workspace terminal output as sufficient: feat(meet): add recording, transcription, and moderation flags #1182 (comment). The current body records maintainer review of that supplied evidence and make ci on the rebased candidate. Original terminal output is no longer embedded in the current body; this review preserves the recorded proof assessment rather than claiming a new live execution. (c642f804a241)
  • Authorization and upgrade boundary: Creation and patching retain the existing account-authenticated Google client and canonical space resolution. Existing scopes already include meetings.space.settings. No credentials, OAuth scopes, dependencies, local serialized state, or storage schema change; omitted settings remain omitted and remote updates use narrow masks. (internal/cmd/meet_update_end.go:69, c642f804a241)

Likely related people:

  • regaw-leinad: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
  • steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (3 earlier review cycles)
  • reviewed 2026-10-01T19:57:29.245Z sha 114728d :: needs changes before merge. :: none
  • reviewed 2026-10-01T20:07:17.888Z sha b37c27a :: needs changes before merge. :: [P3] Include contributor thanks in the Unreleased entry
  • reviewed 2026-10-03T15:31:39.655Z sha b37c27a :: needs changes before merge. :: [P3] Include contributor thanks in the Unreleased entry

@regaw-leinad
regaw-leinad force-pushed the feat/meet-space-config branch from 8c018a1 to b37c27a Compare October 1, 2026 20:01
@regaw-leinad

Copy link
Copy Markdown
Contributor Author

@steipete heads up, the only thing ClawSweeper still flags is the "thanks" line in CHANGELOG.md. Didn't want to thank myself (lol), so I left that one for you if you want to bring this in

Expose explicit settings flags with precise update masks and preserve omitted
configuration. Include regression coverage, command documentation, and
contributor-provided live Workspace evidence in PR openclaw#1182.

Co-authored-by: Dan Wager <danielwager@gmail.com>
@steipete
steipete force-pushed the feat/meet-space-config branch from b37c27a to c642f80 Compare October 7, 2026 04:43
@steipete
steipete merged commit 5bfd659 into openclaw:main Oct 7, 2026
7 of 8 checks passed
@steipete

steipete commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Landed with contributor credit and a credited Unreleased entry. The final candidate passed the full make ci gate on AWS Crabbox (cbx_82fe63e89d13, run run_4a0b311940c195a4e6c3acd02519c6d1) and independent Codex review through P2.

Exact-head CI at c642f804a241994784ae7d7c51d4be1a3d6471ed passed Linux, minimum Go, macOS, Windows, worker, and Docker checks: https://github.com/openclaw/gogcli/actions/runs/37572825243

The implementation preserves omitted settings, uses individual update masks, and rejects conflicting moderation options before authentication. Live Workspace/consumer behavior evidence is the contributor-provided proof summarized in the PR; the live meeting session was not repeated during this landing. Thanks @regaw-leinad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants