Fix: Make "Apply Annual Fees" currency-agnostic for non-INR deployments

[Manishnemade12]

Description

This PR fixes a critical internationalization (i18n) bug where the "Apply Annual Fees" menu option was completely hidden for any Fineract deployment not using the exact <charge-name> - INR convention (such as non-Rupee currencies like USD, EUR, KES, NGN, or localized charge names).

Five occurrences across the Savings, Shares, and Recurring Deposits modules were hardcoded to check charge.name === 'Annual fee - INR'. This string-matching brittle detection model was replaced with the stable, currency-agnostic Fineract API check charge.chargeTimeType?.id === 7. This conforms to Apache Fineract's global charge type enumeration for Annual Fees, ensuring the feature works accurately regardless of location, language, or currency.

Screenshots, if any

(Not applicable, business logic fix enabling hidden dropdown options for localized currencies)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

[coderabbitai]

Warning

Rate limit exceeded

@Manishnemade12 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 49 minutes and 26 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 668c585e-8be7-425d-bd86-2fc4feaa7a83

📥 Commits

Reviewing files that changed from the base of the PR and between ad493a1 and 80edd12.

📒 Files selected for processing (6)

• src/app/clients/clients-view/clients-view.component.ts
• src/app/deposits/recurring-deposits/recurring-deposits-account-view/recurring-deposits-account-view.component.ts
• src/app/loans/loans-view/loans-view.component.ts
• src/app/savings/saving-account-actions/apply-annual-fees-savings-account/apply-annual-fees-savings-account.component.ts
• src/app/savings/savings-account-view/savings-account-view.component.ts
• src/app/shares/shares-account-view/shares-account-view.component.ts

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 49 minutes and 26 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}