Fix lowlight style for dark themes - #7
Merged
san-tekart merged 1 commit intoAug 11, 2026
Merged
Conversation
Member
|
Verified: typecheck clean, 157/157 tests pass. The achromatic-grey fix and the dark-theme brightening both look right, and decoupling the Lowlight underline from readability compensation is a good call — the underline needs contrast against the background, not against the theme. One tiny note: the doc comment on |
san-tekart
added a commit
that referenced
this pull request
Aug 11, 2026
Payload for the 0.1.10 marketplace release: - manifest.json, package.json: 0.1.9 -> 0.1.10 - versions.json: add "0.1.10": "1.5.0" - main.js: freshly rebuilt at 0.1.10 Code changes: - fix(style): apply style body-class to all note-hosting windows instead of activeDocument (#8) — Obsidian 1.13 made Settings a popout window, so the class landed on the Settings window while notes kept the stale style until restart. Adds window-open re-apply for new popouts + 4 regression tests (161/161 total). - (already on main) fix(lowlight): theme-aware underline + achromatic grey fix (#7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lowlight style did not work well with dark themes. Furthermore it had a bug with grey colors that lead to a red underline.
Fixes I made:
Actually nothing changed for light themes (except the red underline fix for grey colors). But I think it looks much better now on dark themes. See the two videos for comparison:
Before:
https://github.com/user-attachments/assets/d7ddd9da-eb13-4fee-9bf9-957af193a5aa
After:
https://github.com/user-attachments/assets/0512bae3-8222-4db2-9afd-3b4f51cbd1f2