Repository navigation
fix stale CLI README example and clippy dead-code CI failure - #173
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CLI documentation example so contributors see the correct Commands enum variants for the ui/cli crate.
Changes:
- Replaces the stale
Sync { slug: Option<String> }example variant with the correctFetchvariant inui/cli/README.md.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ooloth
changed the title
#57 The example showed a Sync variant with a slug parameter that never existed in the codebase. The actual Commands enum has Fetch and Status. Replace the stale example with the correct variants to match main.rs.
WorktreeSpec::CurrentDir is only used by the MediaBlocked investigation, which is behind #[cfg(feature = "private")]. Without the same gate on the variant itself, clippy reports dead_code when building without the private feature, which fails CI (-D warnings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ What
claude/issue-57branch: a stale CLI README example and a clippy dead-code warning that fails CICommandsenum example inui/cli/README.mdto match the actual enum — replaces the nonexistentSync { slug: Option<String> }variant withFetchWorktreeSpec::CurrentDirbehind#[cfg(feature = "private")]to match its only call site, which is already private-gated🤔 Why
CurrentDiris only used by theMediaBlockedinvestigation (private feature), so without the gate clippy reports dead code and CI fails with-D warnings👩🔬 How to validate
ui/cli/README.mdand read theCommandsenum example — expect to seeFetchandStatusvariants with no struct fieldsSyncandslug— expect zero matchesui/cli/src/main.rslines 15–19 — expect the example to match🔖 Related links
Closes #57