fixes three bugs in hex float parsing - #7622
Merged
Merged
Conversation
MatzeOGH
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hex letter digit (a-f) did not reset the trailing-zero counter, so
digits after a zero were stripped: "0x1.0fp0" gave 1.0 (expected 1.05859375).
The loop that shifts a too-long mantissa down used the same condition as
the loop that shifts it up, so it never ran. Mantissas with more than 55
bits were not rounded: "0x1.123456789abcdef0p0" gave 0.0243...
Denormalization used
ifinstead offor, so subnormal results werewrong: "0x1p-1074" gave 0h0008000000000000 instead of 0h0000000000000001.