Repository navigation
Use literal file names in tests - #106
Merged
Merged
Conversation
These tests rely on fixtures include output based on the represention of file paths supplied directly, without any normalization. But in dune 3.24 the representation of variables expanding to paths within the current directory changes to always include the `./` prefix. As a result, these tests will break. The change proposed here uses literal file names rather than dune variables to ensure the tests have a fixed representation the files regardless of the dune version.
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jun 26, 2026
Required due to changes in the representation of paths expanded from dune variables in dune 3.24. An upstream PR is proposed at ocaml-community/cppo#106
liyishuai
approved these changes
Jun 30, 2026
craff
pushed a commit
to craff/opam-repository
that referenced
this pull request
Jul 25, 2026
Required due to changes in the representation of paths expanded from dune variables in dune 3.24. An upstream PR is proposed at ocaml-community/cppo#106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests rely on fixtures include output based on the represention of file paths supplied directly, without any normalization. But in dune 3.24 the representation of variables expanding to paths within the current directory changes to always include the
./prefix. As a result, these tests will break. This was introduced with ocaml/dune#15156Two other alternatives to make these tests pass with dune 3.24 are: