Skip to content

fix: honor architecture selection and repair documentation tooling - #810

Open
OskarEichler wants to merge 1 commit into
oblador:masterfrom
OskarEichler:codex/keychain-tooling-docs
Open

fix: honor architecture selection and repair documentation tooling#810
OskarEichler wants to merge 1 commit into
oblador:masterfrom
OskarEichler:codex/keychain-tooling-docs

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 28, 2026

Copy link
Copy Markdown

Fixes and compatibility

  • Respect an explicit RCT_NEW_ARCH_ENABLED=0 in the example Podfile; keep new architecture as the default. Previously CI requested the old architecture but the Podfile overwrote it with 1.
  • Declare the website's TypeScript dependency so its existing yarn workspace website typecheck script actually resolves tsc under Yarn workspaces.
  • Exclude generated library/docs/native build output from ESLint; a lint run after building otherwise traverses generated bundles and Pods.
  • Repair the documented Jest setup factory's hoisted-variable reference, update current storage enum names, and include internet existence/reset behavior.
  • Correct the FAQ's storage call and its promise of recovering biometrically invalidated credentials. Clarify TEE/StrongBox and security-level requirements without claiming capability queries attest every key.

No shipped runtime API change. Build behavior changes intentionally for callers explicitly opting out of the new architecture. No new package version is introduced: the website reuses the existing TypeScript resolution.

Verification

  • Evaluated the actual Podfile with the installed test-app architecture predicates: unset/0/1 select new/old/new. The explicit-zero case failed before.
  • Transformed the documented Jest factory with Babel's real Jest-hoist plugin; it now passes instead of rejecting the out-of-scope variable.
  • Immutable Yarn install, website typecheck, root lint/types/builds, Docusaurus build, and whitespace checks pass. Baseline website typecheck exited 127 because the workspace had no tsc binary.
  • The focused Podfile/Jest checks also pass with this patch alone over 6be201b.
  • The full iOS old-architecture native build was not repeated; predicate validation must not be read as that platform build claim.

Generated files and checked-in tests are unchanged.

Consumer integration

  • The combined runtime fixes are backported onto released 10.0.0 at immutable artifact dbd32b5, preserving its bridge/error-code and StrongBox policies. Example/tooling-only changes are not shipped in that runtime artifact.
  • On RN 0.87.1, immutable install, lint, both Android Debug products, both unsigned iOS Simulator Debug products, all four production Metro bundles, 13 web targets and four browser extensions pass. All installed package files were verified against the artifact. These are combined-backport integration results, not independent device validation of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant